Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: wildfly-jar doesn't depend on common-maven module #480

Merged
merged 1 commit into from
Nov 5, 2020

Conversation

manusa
Copy link
Member

@manusa manusa commented Nov 5, 2020

Description

fix: wildfly-jar doesn't depend on common-maven module

For some reason wildfly-jar depends on common-maven module. This module should only be used in Maven plugins.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@manusa manusa self-assigned this Nov 5, 2020
@manusa manusa added the bug Something isn't working label Nov 5, 2020
@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #480 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #480   +/-   ##
=========================================
  Coverage     37.76%   37.76%           
  Complexity     2496     2496           
=========================================
  Files           389      389           
  Lines         19167    19167           
  Branches       2797     2797           
=========================================
  Hits           7238     7238           
  Misses        11073    11073           
  Partials        856      856           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cfd127...2f1f70e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Nov 5, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_131) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11.
Read more here

@manusa manusa merged commit a8f7084 into eclipse-jkube:master Nov 5, 2020
@manusa manusa deleted the fix/common-maven branch November 5, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants