-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Removed Guava Functional interfaces #559
Conversation
Codecov Report
@@ Coverage Diff @@
## master #559 +/- ##
============================================
+ Coverage 42.04% 42.10% +0.05%
- Complexity 2840 2845 +5
============================================
Files 402 402
Lines 19461 19458 -3
Branches 2777 2775 -2
============================================
+ Hits 8183 8193 +10
+ Misses 10287 10273 -14
- Partials 991 992 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR 🥳
Please take a look at the following suggestions
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java
Outdated
Show resolved
Hide resolved
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java
Outdated
Show resolved
Hide resolved
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java
Outdated
Show resolved
Hide resolved
86eb90f
to
e2849d9
Compare
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java
Outdated
Show resolved
Hide resolved
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java
Outdated
Show resolved
Hide resolved
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java
Outdated
Show resolved
Hide resolved
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks a lot for your contribution :-)
ef07a12
to
dddebd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, also add a CHANGELONG.md entry.
Everything else LGTM, thx!
jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/EnvUtil.java
Outdated
Show resolved
Hide resolved
dc4fa42
to
10a1eed
Compare
Signed-off-by: ABHIJEET SHUKLA <[email protected]>
311271b
to
64241c2
Compare
Can someone please help me with figuring out the why sonar-pr check is failing? cc @rohanKanojia @manusa @ohbus Below is the tail of log: OpenShift Maven Plugin :: Plugin ................... SUCCESS [ 2.453 s] |
Could you please rebase against master? We recently merged #562 |
Signed-off-by: ABHIJEET SHUKLA <[email protected]>
Kudos, SonarCloud Quality Gate passed! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx
Description
Fix: #546
Type of change
test, version modification, documentation, etc.)
Checklist