Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #639: Configuring Quotas for OpenShift BuildConfig not working as expected #674

Merged
merged 1 commit into from
Apr 29, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Apr 20, 2021

Description

Fix #639

  • Fixed OpenShift BuildConfig not getting picked up bug
  • Add documentation for XML resource configuration options

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@rohanKanojia rohanKanojia changed the title Fix #639: Configuring Quotas for OpenShift BuildConfig not working as… Fix #639: Configuring Quotas for OpenShift BuildConfig not working as expected Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #674 (65c064f) into master (329dc87) will decrease coverage by 0.22%.
The diff coverage is 100.00%.

❗ Current head 65c064f differs from pull request most recent head 7bd16df. Consider uploading reports for the commit 7bd16df to get more accurate results
Impacted file tree graph

@@             Coverage Diff              @@
##             master     #674      +/-   ##
============================================
- Coverage     44.23%   44.00%   -0.23%     
+ Complexity     3058     3035      -23     
============================================
  Files           410      411       +1     
  Lines         19602    19632      +30     
  Branches       2768     2773       +5     
============================================
- Hits           8670     8639      -31     
- Misses         9927     9978      +51     
- Partials       1005     1015      +10     
Impacted Files Coverage Δ Complexity Δ
...be/maven/plugin/mojo/build/AbstractDockerMojo.java 6.86% <100.00%> (+6.86%) 5.00 <0.00> (+5.00)
...eclipse/jkube/kit/enricher/handler/HandlerHub.java 0.00% <0.00%> (-100.00%) 0.00% <0.00%> (-16.00%)
...be/enricher/generic/DefaultControllerEnricher.java 52.11% <0.00%> (-45.72%) 4.00% <0.00%> (ø%)
...pse/jkube/kit/enricher/handler/ProjectHandler.java 0.00% <0.00%> (-20.00%) 0.00% <0.00%> (-1.00%)
...er/generic/openshift/DeploymentConfigEnricher.java 65.57% <0.00%> (-16.78%) 9.00% <0.00%> (-11.00%)
...e/jkube/kit/enricher/handler/NamespaceHandler.java 0.00% <0.00%> (-12.50%) 0.00% <0.00%> (-1.00%)
.../org/eclipse/jkube/kit/enricher/api/util/Misc.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
.../kit/enricher/handler/DeploymentConfigHandler.java 0.00% <0.00%> (ø) 0.00% <0.00%> (?%)
...jkube/kit/enricher/handler/StatefulSetHandler.java 100.00% <0.00%> (+6.25%) 4.00% <0.00%> (ø%)
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 329dc87...7bd16df. Read the comment docs.

@manusa
Copy link
Member

manusa commented Apr 26, 2021

Relates to #551

@rohanKanojia rohanKanojia force-pushed the pr/issue639 branch 2 times, most recently from 9c833e7 to a88e838 Compare April 27, 2021 06:47
Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

…ot working as expected

+ Fixed OpenShift BuildConfig not getting picked up bug
+ Add documentation for XML resource configuration options in different
  enrichers wherever applicable
@sonarcloud
Copy link

sonarcloud bot commented Apr 29, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 00512cd into eclipse-jkube:master Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Quotas for jkube.build.strategy docker
2 participants