-
Notifications
You must be signed in to change notification settings - Fork 522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #639: Configuring Quotas for OpenShift BuildConfig not working as expected #674
Conversation
Codecov Report
@@ Coverage Diff @@
## master #674 +/- ##
============================================
- Coverage 44.23% 44.00% -0.23%
+ Complexity 3058 3035 -23
============================================
Files 410 411 +1
Lines 19602 19632 +30
Branches 2768 2773 +5
============================================
- Hits 8670 8639 -31
- Misses 9927 9978 +51
- Partials 1005 1015 +10
Continue to review full report at Codecov.
|
...ven-plugin/plugin/src/test/java/org/eclipse/jkube/maven/plugin/mojo/build/BuildMojoTest.java
Outdated
Show resolved
Hide resolved
7b6c23b
to
398850c
Compare
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/_enricher.adoc
Outdated
Show resolved
Hide resolved
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/_enricher.adoc
Outdated
Show resolved
Hide resolved
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/_enricher.adoc
Outdated
Show resolved
Hide resolved
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/enricher/_jkube-metadata.adoc
Outdated
Show resolved
Hide resolved
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/enricher/_jkube-metadata.adoc
Outdated
Show resolved
Hide resolved
Relates to #551 |
32d90c9
to
65c064f
Compare
kubernetes-maven-plugin/doc/src/main/asciidoc/inc/enricher/_jkube_docker-registry-secret.adoc
Outdated
Show resolved
Hide resolved
9c833e7
to
a88e838
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
…ot working as expected + Fixed OpenShift BuildConfig not getting picked up bug + Add documentation for XML resource configuration options in different enrichers wherever applicable
Kudos, SonarCloud Quality Gate passed! |
Description
Fix #639
Type of change
test, version modification, documentation, etc.)
Checklist