Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Kubernetes-Client Version to 4.7.1 #70

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Updated Kubernetes-Client Version to 4.7.1 #70

merged 1 commit into from
Feb 27, 2020

Conversation

devang-gaur
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 20, 2020 •
edited
Loading

Codecov Report

Merging #70 into master will decrease coverage by 0.03%.
The diff coverage is 6.12%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #70      +/-   ##
============================================
- Coverage     24.54%   24.51%   -0.04%     
  Complexity     1334     1334              
============================================
  Files           326      326              
  Lines         17579    17603      +24     
  Branches       2689     2679      -10     
============================================
  Hits           4315     4315              
- Misses        12767    12789      +22     
- Partials        497      499       +2
Impacted Files Coverage Δ Complexity Δ
...ipse/jkube/enricher/generic/ConfigMapEnricher.java 78.46% <0%> (ø) 13 <0> (ø) ⬇️
...jkube/maven/enricher/handler/NamespaceHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ube/enricher/generic/DefaultNamespaceEnricher.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...be/maven/enricher/api/visitor/MetadataVisitor.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...e/jkube/maven/enricher/handler/ProjectHandler.java 0% <0%> (ø) 0 <0> (ø) ⬇️
...ava/org/eclipse/jkube/kit/common/util/MapUtil.java 62.5% <0%> (-6.25%) 5 <2> (ø)
...ube/enricher/generic/VolumePermissionEnricher.java 77.64% <0%> (ø) 2 <0> (ø) ⬇️
...e/jkube/enricher/generic/ProjectLabelEnricher.java 58.73% <42.85%> (-3.34%) 7 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9449795...8afbf88. Read the comment docs.

@rohanKanojia rohanKanojia self-requested a review February 20, 2020 06:54
@devang-gaur devang-gaur force-pushed the client_version branch 4 times, most recently from 2b0f653 to 51c05ce Compare February 25, 2020 09:17
rohanKanojia
rohanKanojia reviewed Feb 25, 2020
View reviewed changes
Copy link
Member

@rohanKanojia rohanKanojia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

There is one minor code smell for unused import. Could you please remove it so that we can proceed with merge?

CHANGELOG.md Outdated
@@ -43,6 +42,8 @@ Usage:
* Doc: Add documentation #38
* Add Sample Quickstarts to project #33
* Fix: Run tests for current version #35
* Updated Kubernetes-Client Version to 4.7.1
* Refactor #29: Add Maven Enforcer Plugin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

...enricher/api/src/main/java/org/eclipse/jkube/maven/enricher/api/visitor/MetadataVisitor.java Outdated
@@ -210,7 +210,9 @@ protected Kind getKind() {

@Override
protected ObjectMeta getOrCreateMetadata(ReplicationControllerBuilder item) {
return item.hasMetadata() ? item.buildMetadata() : item.withNewMetadata().endMetadata().buildMetadata();
//return item.hasMetadata() ? item.buildMetadata() : item.withNewMetadata().endMetadata().buildMetadata();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove these commented section

jkube-kit/parent/pom.xml
@@ -57,7 +57,7 @@
<version.json-path-assert>2.2.0</version.json-path-assert>
<version.jsr305>3.0.2</version.jsr305>
<version.JUnitParams>1.0.5</version.JUnitParams>
<version.kubernetes-client>4.6.2</version.kubernetes-client>
<version.kubernetes-client>4.7.1</version.kubernetes-client>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we upgrade to 4.8.0 instead?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As JKube requires CQ to upgrade a dependency, I'd merge this one once the rest of the comments are fine.
Then do the upgrade to 4.8.0 in the scope of another issue.
Else we'll be stuck forever.

@devang-gaur
Copy link
Contributor Author

http://dev.eclipse.org/ipzilla/show_bug.cgi?id=21606
http://dev.eclipse.org/ipzilla/show_bug.cgi?id=21605

CQs have been resolved. Shall we proceed to merge?

rohanKanojia
rohanKanojia reviewed Feb 26, 2020
View reviewed changes
...it/enricher/api/src/main/java/org/eclipse/jkube/maven/enricher/handler/NamespaceHandler.java Outdated
@@ -15,6 +15,7 @@

import io.fabric8.kubernetes.api.model.Namespace;
import io.fabric8.kubernetes.api.model.NamespaceStatus;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please remove this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@rohanKanojia rohanKanojia merged commit 645268c into eclipse-jkube:master Feb 27, 2020
@manusa
Copy link
Member

manusa commented Feb 27, 2020

Relates to: #50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@manusa manusa manusa approved these changes

@rohanKanojia rohanKanojia rohanKanojia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@devang-gaur @manusa @rohanKanojia