Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECR authorization Token URL #718

Merged
merged 1 commit into from
Jun 14, 2021

Conversation

rohanKanojia
Copy link
Member

@rohanKanojia rohanKanojia commented Jun 11, 2021

Description

Port of fabric8io/docker-maven-plugin#1318

Related to #702

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

@codecov
Copy link

codecov bot commented Jun 11, 2021

Codecov Report

Merging #718 (b564331) into master (c01c5c3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #718   +/-   ##
=========================================
  Coverage     45.01%   45.01%           
  Complexity     3127     3127           
=========================================
  Files           413      413           
  Lines         19645    19645           
  Branches       2761     2761           
=========================================
  Hits           8843     8843           
  Misses         9791     9791           
  Partials       1011     1011           
Impacted Files Coverage Δ
...ild/service/docker/auth/ecr/AwsSigner4Request.java 75.32% <ø> (ø)
...build/service/docker/auth/ecr/EcrExtendedAuth.java 90.47% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c01c5c3...b564331. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@manusa manusa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx!

@manusa manusa merged commit b733594 into eclipse-jkube:master Jun 14, 2021
@manusa manusa added this to the 1.4.0 milestone Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants