-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How VSS2DBC signal gets data of other signals of same frame #23
Comments
You are right on the general mapping as described in https://github.com/eclipse-kuksa/kuksa-can-provider/blob/main/mapping/README.md
This is (currently) based on an assumption that actual values only flow in the direction from CAN to Databroker, and target values in direction from Databroker to CAN. We do not have as of today any mechanism to specify that sensor values should be used on CAN or that CAN will provide target/actuator values to Databroker. This is how values in vss2dbc is handled: At startup the CAN provider subscribes to target values of all VSS signals listed in
When CAN provider receives a target value update callback from Databroker it:
Population use two methods:
So what will be included in the CAN frame is either default values from JSON or actuator/target values from other |
Thanks for the quick reply and answer @erikbosch, Is there an option, that it will look for current value of the VSS and sends that ? While testing I have noticed 2 that VSS signals of sensor, Can't able to set the target value but in https://github.com/eclipse-kuksa/kuksa-can-provider/blob/973fe305f470db216ceddb619c11df7a77adb7a2/mapping/vss_4.1/dbc_overlay.vspec#L300C3-L300C7 for type of sensor vss2dbc is defined |
It would technically not be a problem to extend the syntax of the mapping with something like For |
Related to eclipse-kuksa#23 Current CAN provider implementation always subscribe to target value for "vss2dbc". That does not really make sense for sensors, as they do not have target values
Related to eclipse-kuksa#23 Current CAN provider implementation always subscribe to target value for "vss2dbc". That does not really make sense for sensors, as they do not have target values
Related to eclipse-kuksa#23 Current CAN provider implementation always subscribe to target value for "vss2dbc". That does not really make sense for sensors, as they do not have target values
Related to #23 Current CAN provider implementation always subscribe to target value for "vss2dbc". That does not really make sense for sensors, as they do not have target values
I have exploring kuksa can providers, amazing work.
I have a doubt on hwo VSS2DBC gets the value of other(affected) signals of the same frame,
I understood that a single VSS signal will have DBC2VSS(current) and VSS2DBC(target),
if i set target value of a VSS signal,
Does it takes other signal value in the following order ?
1.) check current_value of the signal
2.)check target_value of the signal
3.) check for default values in the json
I have a doubt whether it takes target value or current value
and does a single VSS signal will have both current and target ? or will it be different VSS signals ?
and if it is a same signal while it be actuator? / I tried to set target value for sensor type VSS signal and it throws error
please correct me, if i am wrong
The text was updated successfully, but these errors were encountered: