Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

splitAttributes keeps first attribute on same line #161

Merged
merged 1 commit into from
Oct 12, 2018
Merged

splitAttributes keeps first attribute on same line #161

merged 1 commit into from
Oct 12, 2018

Conversation

NikolasKomonen
Copy link
Contributor

@NikolasKomonen NikolasKomonen commented Oct 11, 2018 •
edited
Loading

@alesso-x
Copy link

alesso-x commented Oct 11, 2018 •
edited
Loading

@NikolasKomonen thanks for fixing this issue so quickly! I just have one question about the PR. I noticed in the test testSplitAttributes that the first attribute is on the same line as the element. In the issue I submitted redhat-developer/vscode-xml#59 I was only concerned about elements with one attribute not being moved. Would it be possible to keep the existing behavior when there are multiple attributes on a element with the first attribute starting on a new line? Thanks again!

@NikolasKomonen
Copy link
Contributor Author

NikolasKomonen commented Oct 12, 2018 •
edited
Loading

@alessandrodimarco sure, I just wasn't sure what people preferred so this will be fine.

@angelozerr
Copy link
Contributor

@NikolasKomonen can I merge it?

@NikolasKomonen
Copy link
Contributor Author

@angelozerr yup, ill do it.

@NikolasKomonen NikolasKomonen merged commit 0d0dbaa into eclipse-lemminx:master Oct 12, 2018
@NikolasKomonen NikolasKomonen deleted the splitAttributesFix branch October 12, 2018 16:52
@NikolasKomonen NikolasKomonen added this to the v0.0.2 milestone Oct 12, 2018
@fbricon fbricon mentioned this pull request Nov 7, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.0.2
Development

Successfully merging this pull request may close these issues.
3 participants
@NikolasKomonen @alesso-x @angelozerr