Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify base of the FrontEnd hierarchy #7540

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

0xdaryl
Copy link
Contributor

@0xdaryl 0xdaryl commented Nov 12, 2024

Simplify and cleanup the base of the FrontEnd hierarchy in preparation for future refactoring work to provide a consistent base for all downstream projects.

Eliminate FEBase, FECommon, and ConcreteFE as they were part of an early FrontEnd design prior to open sourcing.

Make JitConfig an extensible class in preparation for consuming project specialization.

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Nov 12, 2024

Jenkins build all

@AdamBrousseau
Copy link
Contributor

jenkins build arm,aarch64

1 similar comment
@AdamBrousseau
Copy link
Contributor

jenkins build arm,aarch64

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Nov 12, 2024

jenkins build arm,aarch64

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Nov 12, 2024

jenkins build arm,aarch64

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Nov 12, 2024

Jenkins build all

@0xdaryl
Copy link
Contributor Author

0xdaryl commented Nov 13, 2024

@mstoodle : I'd appreciate a review from you on this

@dsouzai : I'd like a review from you too, and ask that you drive the eventual coordinated merge with the downstream OpenJ9 when it is ready

@0xdaryl 0xdaryl changed the title WIP: Simplify base of the FrontEnd hierarchy Simplify base of the FrontEnd hierarchy Nov 13, 2024
Use the proper extensible class for JitConfig rather than the version in FETraits.
Remove FETraits.

Signed-off-by: Daryl Maier <[email protected]>
* Eliminate FEBase, FECommon, and ConcreteFE
* Remove unused Z FrontEnd function generateBinaryEncodingPrologue()
* Eliminate some unnecessary #includes

FrontEnd is not a true extensible class yet because of downstream dependencies
on the existing compiler/env/FrontEnd.hpp.

Signed-off-by: Daryl Maier <[email protected]>
Copy link
Contributor

@dsouzai dsouzai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants