-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify base of the FrontEnd hierarchy #7540
Open
0xdaryl
wants to merge
5
commits into
eclipse-omr:master
Choose a base branch
from
0xdaryl:frontend
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins build all |
jenkins build arm,aarch64 |
1 similar comment
jenkins build arm,aarch64 |
jenkins build arm,aarch64 |
jenkins build arm,aarch64 |
Jenkins build all |
0xdaryl
changed the title
WIP: Simplify base of the FrontEnd hierarchy
Simplify base of the FrontEnd hierarchy
Nov 13, 2024
Signed-off-by: Daryl Maier <[email protected]>
Signed-off-by: Daryl Maier <[email protected]>
Use the proper extensible class for JitConfig rather than the version in FETraits. Remove FETraits. Signed-off-by: Daryl Maier <[email protected]>
* Eliminate FEBase, FECommon, and ConcreteFE * Remove unused Z FrontEnd function generateBinaryEncodingPrologue() * Eliminate some unnecessary #includes FrontEnd is not a true extensible class yet because of downstream dependencies on the existing compiler/env/FrontEnd.hpp. Signed-off-by: Daryl Maier <[email protected]>
Signed-off-by: Daryl Maier <[email protected]>
dsouzai
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok to me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify and cleanup the base of the FrontEnd hierarchy in preparation for future refactoring work to provide a consistent base for all downstream projects.
Eliminate FEBase, FECommon, and ConcreteFE as they were part of an early FrontEnd design prior to open sourcing.
Make JitConfig an extensible class in preparation for consuming project specialization.