(0.49.0) Fix syncTempTrampolines when startPC returns 0 #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When syncing temporary trampolines, there is a call to startPC with the callee method to try and get the start PC. If the latest compilation of that method failed, startPC returns zero which is not a real start PC and can not be used as a target for a trampoline. Attempting to do so will cause an error. This change adds error checking when trying to sync trampolines. When a start PC of zero is returned from the call to startPC, the previous start PC is used instead. Signed-off-by: jimmyk <[email protected]>
pshipton
approved these changes
Nov 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing temporary trampolines, there is a call to startPC with the callee method to try and get the start PC. If the latest compilation of that method failed, startPC returns zero which is not a real start PC and can not be used as a target for a trampoline. Attempting to do so will cause an error.
This change adds error checking when trying to sync trampolines. When a start PC of zero is returned from the call to startPC, the previous start PC is used instead.
Backport of eclipse-omr/omr#7550