Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement StackWalker.Option.DROP_METHOD_INFO #18160

Merged
merged 1 commit into from
Sep 20, 2023
Merged

Implement StackWalker.Option.DROP_METHOD_INFO #18160

merged 1 commit into from
Sep 20, 2023

Conversation

keithc-ca
Copy link
Contributor

Fixes: #18146.

  • copy flags from StackWalker to StackFrameImpl objects
  • thrown UnsupportedOperationException as appropriate
  • skip collecting method details if DROP_METHOD_INFO was specified

Tidy up:

  • use parentheses consistently
  • use J9_ARE_ANY_BITS_SET for testing a single bit
  • cast carefully

@keithc-ca
Implement StackWalker.Option.DROP_METHOD_INFO
870f211 
* copy flags from StackWalker to StackFrameImpl objects
* thrown UnsupportedOperationException as appropriate
* skip collecting method details if DROP_METHOD_INFO was specified

Tidy up:
* use parentheses consistently
* use J9_ARE_ANY_BITS_SET for testing a single bit
* cast carefully

Signed-off-by: Keith W. Campbell <[email protected]>
@pshipton
Copy link
Member

jenkins test sanity.openjdk amac jdk21,jdknext

@tajila
Copy link
Contributor

tajila commented Sep 20, 2023 •
edited
Loading

are these known test failures?

Failed test cases: 
TEST: java/lang/invoke/MethodHandleProxies/BasicTest.java
TEST: java/lang/invoke/MethodHandleProxies/Driver.java
TEST: java/lang/invoke/MethodHandleProxies/WithSecurityManagerTest.java
TEST: java/lang/invoke/MethodHandleProxies/WrapperHiddenClassTest.java
TEST: java/lang/ScopedValue/StressStackOverflow.java#default
TEST: java/lang/ScopedValue/StressStackOverflow.java#TieredStopAtLevel1
TEST: java/lang/ScopedValue/StressStackOverflow.java#no-vmcontinuations
TEST: java/lang/System/LoggerFinder/RecursiveLoading/PlatformRecursiveLoadingTest.java
TEST: java/lang/System/LoggerFinder/RecursiveLoading/RecursiveLoadingTest.java
TEST: java/lang/ScopedValue/StressStackOverflow.java#no-TieredCompilation
Test results: passed: 919; failed: 10



  | Failed test cases:  TEST: java/util/stream/test/org/openjdk/tests/java/lang/invoke/MHProxiesTest.java Test results: passed: 952; failed: 1
-- | --

@keithc-ca
Copy link
Contributor Author

are these known test failures?

Yes, I think so. For example, see:

@tajila tajila merged commit e76263e into eclipse-openj9:master Sep 20, 2023
@keithc-ca keithc-ca deleted the drop_method_info branch September 20, 2023 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pshipton pshipton pshipton approved these changes

@tajila tajila tajila approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement StackWalker.Option.DROP_METHOD_INFO
3 participants
@keithc-ca @pshipton @tajila