Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force inline AbstractMemorySegmentImpl.reinterpret for getCallerClass optimization #20471

Merged
merged 2 commits into from
Nov 5, 2024
Merged

Force inline AbstractMemorySegmentImpl.reinterpret for getCallerClass optimization #20471

merged 2 commits into from
Nov 5, 2024

Commits on Nov 4, 2024

  1. Add AbstractMemorySegmentImpl.reinterpret as a recognized method 

    Signed-off-by: Nazim Bhuiyan <[email protected]>
    @nbhuiyan
    nbhuiyan committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    aa224e1 View commit details
    Browse the repository at this point in the history

  2. Set AbstractMemorySegmentImpl.reinterpret as always worth inlining 

    AbstractMemorySegmentImpl.reinterpret methods contain calls to
Reflection.getCallerClass. Optimization of getCallerClass requires
the caller to be inlined. Otherwise, we would end up using the
JNI helper which performs a very expensive stackwalk to obtain
the caller class.

Signed-off-by: Nazim Bhuiyan <[email protected]>
    @nbhuiyan
    nbhuiyan committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    2280db2 View commit details
    Browse the repository at this point in the history