Implement Unsafe opaque and acquire/release put and get methods #20475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spencer-Comin
force-pushed
the
acqrel-opaque
branch
2 times, most recently
from
ea54426
to
2d7a599
Compare
Spencer-Comin
requested review from
0xdaryl,
hzongaro,
vijaysun-omr and
zl-wang
Spencer-Comin
force-pushed
the
acqrel-opaque
branch
2 times, most recently
from
6c94b6b
to
12739fb
Compare
With the expansion of possible memory ordering semantics from binary volatile or non-volatile to volatile, acquire/release, opaque, and transparent, all tests whether a symbol is volatile need to be refined depending on the intention of the test, i.e. is it testing if the symbol is strictly volatile, simply opaque, or somewhere in between? Signed-off-by: Spencer Comin <[email protected]>
Add opaque and acquire/release flavours of get put methods in Unsafe as recognized methods, and generate unsafe shadow symbols with the correct access modes when inlining these methods. Signed-off-by: Spencer Comin <[email protected]>
Since Unsafe.putOrdered is fully supported through acquire/release symbols, we no longer need to duplicate the call tree to prevent incorrect optimizations. Signed-off-by: Spencer Comin <[email protected]>
Spencer-Comin
force-pushed
the
acqrel-opaque
branch
from
12739fb
to
fbe3466
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement the Unsafe get and put methods with opaque and acquire/release memory semantics by using the corresponding access modes on the unsafe shadow symbols as introduced in eclipse-omr/omr#7517.
Note that this requires a coordinated merge with eclipse-omr/omr#7517.