JFR: Prevent chunk buffer overflows #20504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
jenkins test sanity.functional xlinux jdk11 |
|
jenkins test sanity.functional alinux64 jdk11 |
tajila
changed the title
tajila
changed the title
|
@gacholio Please review these changes |
gacholio
reviewed
Nov 5, 2024
gacholio
reviewed
Nov 5, 2024
gacholio
reviewed
Nov 5, 2024
Detect chunk buffer overflow and prevent subsequent writes to the buffer. Also, update chunk buffer size calculations. Skip frames with incomplete data in stacktraces. Add missing memory frees. Signed-off-by: tajila <[email protected]>
gacholio
approved these changes
Nov 6, 2024
|
jenkins compile win,xlinux jdk21 |
keithc-ca
reviewed
Nov 6, 2024
Comment on lines
+243
to
245
| if (!_isLE) { | ||
| newVal = byteSwap(val); | ||
| } |
There was a problem hiding this comment.
I don't think calling byteSwap() is appropriate for any platform here or in any writeLEB* method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect chunk buffer overflow and prevent subsequent writes to the buffer. Also, update chunk buffer size calculations.
Skip frames with incomplete data in stacktraces.
Add missing memory frees.