Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default port for wss:// should be 443 #1048

Closed
yulius-take2 opened this issue Jan 20, 2021 · 1 comment
Closed

Default port for wss:// should be 443 #1048

yulius-take2 opened this issue Jan 20, 2021 · 1 comment

Comments

@yulius-take2
Copy link

Describe the bug
MQTTProtocol_connect() does not parse wss://domain.com/mqtt properly. It will parse as 8883 instead of 443. The work around is to set the URL as wss://domain.com:443/mqtt.

To Reproduce
Take a library trace as outlined in the README, and/or have a program or describe the steps to reproduce the behavior:

  1. Create paho client and connect to wss://domain.com/mqtt
  2. Put a breakpoint on MQTTProtocol_connect and MQTTProtocol_addressPort.
  3. Step through and notice the port returned from MQTTProtocol_addressPort is 8883 instead of 443.

Expected behavior
We can connect using wss://domain.com/mqtt

Screenshots
N/A

** Environment (please complete the following information):**

  • OS: Windows
  • Version 10

Additional context
N/A

@icraggs
Copy link
Contributor

icraggs commented Jan 20, 2021

Yes, there is no websockets secure port default at the moment.

@icraggs icraggs added this to the 1.3.9 milestone Jan 20, 2021
@icraggs icraggs added the bug label Jan 20, 2021
@icraggs icraggs changed the title MQTTProtocol_connect() does not parse wss://domain.com/mqtt properly as the broker url Default port for wss:// should be 443 Jan 20, 2021
icraggs added a commit that referenced this issue Jan 28, 2022
icraggs added a commit that referenced this issue Jan 28, 2022
@icraggs icraggs modified the milestones: 1.4.0, 1.3.10 Jan 29, 2022
@icraggs icraggs closed this as completed Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants