-
Notifications
You must be signed in to change notification settings - Fork 727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
address #713: remove claims of python2 support, as it is no longer su… #757
address #713: remove claims of python2 support, as it is no longer su… #757
Conversation
…no longer supported.
This looks good to me. Even if somehow the current codebase did work with 2.7 (despite #713 saying it can't), I think it's just as well to declare that we're done with 2.7, freeing people to do things that break compat, and telling potential users that it won't work. So I'm +1 on merging this. |
@akx Your review, please. Python 2 died 1,392 days ago on 1/1/2020. |
@cclauss I'm not sure why you'd want my review here? If anything, @petersilva please add "Closes #714" to the PR's description, so if it does get merged, my "counter-PR" will get closed. |
Weirdly... this PR is approved by @cclauss, but it still isn't merged... what other steps are needed? |
@petersilva Thanks, but please also add the magic phrase As for how to get this merged, I don't think @cclauss is a maintainer of this repo, so you'd have to wait for someone else, I suppose – your CI workflows haven't been run yet, for one, and that requires maintainer approval. |
Correct. I am not a maintainer of this repo. Maintainers will have a green ✅ next to their pull request approvals but mine above is merely ☑️ . |
Thanks for this contribution and for your patience |
#713 mentions that paho documentation says that it should be compatible with python 2.7. Someone answered that python2.7 is not supported.
So this PR corrects the documentation, and metadata to remove claims about python 2 support for the current version.