Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

address #713: remove claims of python2 support, as it is no longer su… #757

Merged

Conversation

petersilva
Copy link
Contributor

@petersilva petersilva commented Oct 17, 2023

#713 mentions that paho documentation says that it should be compatible with python 2.7. Someone answered that python2.7 is not supported.

So this PR corrects the documentation, and metadata to remove claims about python 2 support for the current version.

@gdt
Copy link

gdt commented Oct 20, 2023

This looks good to me. Even if somehow the current codebase did work with 2.7 (despite #713 saying it can't), I think it's just as well to declare that we're done with 2.7, freeing people to do things that break compat, and telling potential users that it won't work. So I'm +1 on merging this.

@cclauss
Copy link
Contributor

cclauss commented Oct 24, 2023

@akx Your review, please. Python 2 died 1,392 days ago on 1/1/2020.

@akx
Copy link
Contributor

akx commented Oct 25, 2023

@cclauss I'm not sure why you'd want my review here?

If anything, @petersilva please add "Closes #714" to the PR's description, so if it does get merged, my "counter-PR" will get closed.

@petersilva
Copy link
Contributor Author

@akx I updated the original comment to mention #714.

@petersilva
Copy link
Contributor Author

Weirdly... this PR is approved by @cclauss, but it still isn't merged... what other steps are needed?

@akx
Copy link
Contributor

akx commented Oct 27, 2023

@petersilva Thanks, but please also add the magic phrase Closes #714 so GitHub will automatically do the right thing if this gets merged.

As for how to get this merged, I don't think @cclauss is a maintainer of this repo, so you'd have to wait for someone else, I suppose – your CI workflows haven't been run yet, for one, and that requires maintainer approval.

@cclauss
Copy link
Contributor

cclauss commented Oct 27, 2023

I don't think @cclauss is a maintainer of this repo

Correct. I am not a maintainer of this repo. Maintainers will have a green ✅ next to their pull request approvals but mine above is merely ☑️ .

@petersilva
Copy link
Contributor Author

Thanks for the clarification... and the review from @cclauss ... magic incantation added for @akx ... awaiting the blessing of the appropriately annointed.

@cclauss
Copy link
Contributor

cclauss commented Nov 14, 2023

@ralight @PierreF Can you please tell us if there are still active maintainers of this repo? Serious upgrading like this pull request is needed to keep this codebase up-to-date. Can we at least get these workflows run to see if they pass?

@PierreF PierreF merged commit b57d0cf into eclipse-paho:master Dec 20, 2023
@PierreF
Copy link
Contributor

PierreF commented Dec 20, 2023

Thanks for this contribution and for your patience

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

paho 1.6.x is _not_ compatible with Python 2.7
5 participants