[GTK4] Migrate deprecated FontChooser to FontDialog #1583
Conversation
ptziegler
force-pushed
the
gtk4-font-dialog
branch
from
d451171
to
7c29698
Compare
|
In terms of appearance, both dialogs are pretty much identical, though I think the old one looks better... GTK3: GTK4:
|
Test Results 483 files ±0 483 suites ±0 8m 58s ⏱️ -56s For more details on these failures, see this check. Results for commit a20a58e. ± Comparison against base commit 2cc00b7. ♻️ This comment has been updated with latest results. |
|
This PR should be kept strictly to FontChooser->FontDialog change and the async helper code change together with adopting existing code should go into #1582 |
Of course, that's why this is still marked as "draft" :) The plan was to wait for the other refactoring to be merged, do a rebase and then the offending commit should disappear on its own. I just didn't want to use the "old" approach when refactoring it anyway. |
|
@ptziegler we have now GTK4 build enabled, so if you rebase your PR it will at last check that compilation has no issues! |
ptziegler
force-pushed
the
gtk4-font-dialog
branch
from
7c29698
to
28866b6
Compare
|
Please continue with this one. |
This moves all native FontChooser bindings from the shared GTK to the GTK3 component and also defines new GTK4 bindings for the FontDialog API. Note: The FontDialog doesn't seem to remember the initial font that is passed as an argument. This looks like a bug within GTK, given that the same behavior also happens for the FontDialogButton[1]. [1] - https://gitlab.gnome.org/GNOME/gtk/-/issues/6892
ptziegler
force-pushed
the
gtk4-font-dialog
branch
from
28866b6
to
a20a58e
Compare
| public void async(long callback) { | ||
| // The font dialog ignores the given font and simply picks the first installed font | ||
| // See https://gitlab.gnome.org/GNOME/gtk/-/issues/6892 | ||
| GTK4.gtk_font_dialog_choose_font(handle, shellHandle, font.handle, 0, callback, 0); |
There was a problem hiding this comment.
As described in the linked issue: What exactly is the procedure for dealing with actual bugs in GTK? As far as I can tell, there is no way to work around this problem inside of SWT.
This moves all native FontChooser bindings from the shared GTK to the GTK3 component and also defines new GTK4 bindings for the FontDialog API.
Note: The FontDialog doesn't seem to remember the initial font that is passed as an argument. This looks like a bug within GTK, given that the same behavior also happens for the FontDialogButton[1].
[1] - https://gitlab.gnome.org/GNOME/gtk/-/issues/6892