Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate TypedListener for removal to make it strongly internal later #1616

Conversation

HannesWell
Copy link
Member

The class TypedListener is intended to be internal even if it's in a public package and because there were cases where it has to be used for custom widges it happened that it was still used. With the APIs introduced in #1112 there are better solutions using only public APIs for the cases it was still used.

Together with #1615 this is the continuation of #1101 (comment) to deprecate TypedListener for removal so that it can later be moved into an internal package to strengthen the statement that it's internal.

Eclipse Nebula also does not use

Copy link
Contributor

github-actions bot commented Nov 24, 2024

Test Results

   483 files  ±0     483 suites  ±0   8m 57s ⏱️ -57s
 4 095 tests ±0   4 085 ✅ ±0   7 💤 ±0  3 ❌ ±0 
16 173 runs  ±0  16 080 ✅ ±0  90 💤 ±0  3 ❌ ±0 

For more details on these failures, see this check.

Results for commit ed4b5f3. ± Comparison against base commit 2cc00b7.

♻️ This comment has been updated with latest results.

@HannesWell HannesWell force-pushed the deprecate-TypedListener-for-removal branch from e7dec2f to 573aee0 Compare November 27, 2024 20:49
@HannesWell HannesWell force-pushed the deprecate-TypedListener-for-removal branch from 573aee0 to ed4b5f3 Compare November 27, 2024 20:55
@HannesWell
Copy link
Member Author

HannesWell commented Nov 27, 2024

It looks like there is no reference to this class in the Eclipse-SDK (anymore).

So if there are no objections about continuing this, I plan to submit it tomorrow evening.

@HannesWell HannesWell merged commit cfa74b4 into eclipse-platform:master Nov 28, 2024
8 of 14 checks passed
@HannesWell HannesWell deleted the deprecate-TypedListener-for-removal branch November 28, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant