Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress "spec has no expectations" warning #1235

Open
wants to merge 1 commit into
base: releases/24.2
Choose a base branch
from
Open

Suppress "spec has no expectations" warning #1235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eclipse-scout-core/test/desktop/hybrid/HybridManagerSpec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ describe('HybridManager', () => {

describe('callActionAndWait', () => {
it('calls a HybridAction and waits for its completion', done => {
expect(true).toBeTrue(); // suppress "spec has no expectations" warning
const id = '42';
UuidPool.get(session).uuids.push(id);
HybridManager.get(session).callActionAndWait('Ping').then(() => done());
Expand All @@ -108,6 +109,7 @@ describe('HybridManager', () => {

describe('openForm', () => {
it('waits for a form to be opened and listens for form events', done => {
expect(true).toBeTrue(); // suppress "spec has no expectations" warning
const id = '42';
UuidPool.get(session).uuids.push(id);
HybridManager.get(session).openForm('Dummy').then(form => {
Expand Down
3 changes: 2 additions & 1 deletion eclipse-scout-core/test/form/fields/listbox/ListBoxSpec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2010, 2023 BSI Business Systems Integration AG
* Copyright (c) 2010, 2024 BSI Business Systems Integration AG
*
* This program and the accompanying materials are made
* available under the terms of the Eclipse Public License 2.0
Expand Down Expand Up @@ -464,6 +464,7 @@ describe('ListBox', () => {

it('has rows with aria role option', () => {
let listBox = createFieldWithLookupCall();
jasmine.clock().tick(500);
listBox.table.rows.forEach(row => {
expect(row.$row).toHaveAttr('role', 'option');
});
Expand Down
1 change: 1 addition & 0 deletions eclipse-scout-core/test/util/objectsSpec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,6 +867,7 @@ describe('objects', () => {

it('uses a type predicate to narrow the type', () => {
// compile time test, ifs are always false
expect(true).toBeTrue(); // suppress "spec has no expectations" warning

let menuClass: new() => Menu;
if (objects.isSameOrExtendsClass(menuClass, Action)) {
Expand Down