Add electron tests #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xai
force-pushed
the
electron-playwright
branch
from
62ccbe6
to
3685880
Compare
xai
force-pushed
the
electron-playwright
branch
2 times, most recently
from
c4cc3a8
to
8ff3f08
Compare
xai
force-pushed
the
electron-playwright
branch
2 times, most recently
from
bddfe24
to
5c31aa0
Compare
planger
reviewed
Mar 26, 2024
.github/workflows/main.yml
Outdated
| python-version: "3.11" | ||
|
|
||
| - name: Test (playwright electron) | ||
| uses: GabrielBB/xvfb-action@v1 |
There was a problem hiding this comment.
We should probably avoid using this GH action, as it is deprecated.
.github/workflows/performance.yml
Outdated
| with: | ||
| node-version: "16.x" | ||
| registry-url: "https://registry.npmjs.org" | ||
| - name: Use Python 3.x |
There was a problem hiding this comment.
Don't we need to pin this to version 3.11?
xai
force-pushed
the
electron-playwright
branch
from
5c31aa0
to
969c59e
Compare
|
I also noticed that we currently use several different versions of actions in the workflows (e.g., v2, v3, and v4 of checkout). If that is ok, I would create a follow-up PR to fix this while at the same time replacing the (mutable) tags with commit hashes. |
planger
reviewed
Mar 27, 2024
There was a problem hiding this comment.
Thank you very much @xai! This looks great so far. I'm eager to try it on the CI infrastructure.
Aside from a minor comment inline I just wanted to double-check the following questions:
- Do we keep the history of the browser performance tests when switching base directory or is there something we need to do?
- How does it impact the allure reports when both browser and electron write into the same allure-results folders before we generate the allure report? Are they then both showing up in the report or does one override the other?
- Can we push a simple
performance/index.htmlwith two links that point toperformance/Browserandperformance/Electronto allow people who still may have the old link to navigate to the reports instead of getting a 404? Or would that be cumebrsome? - As a follow-up we should also update the readme and modify/add the badge to point to both of the performance pages.
tests/theia-text-editor.test.ts
Outdated
Comment on lines
37
to
45
| if (app.isElectron) { | ||
| const explorer = await app.openView(TheiaExplorerView); | ||
| await explorer.waitForVisibleFileNodes(); | ||
| console.log(`app.workspace.path = ${app.workspace.path}`); | ||
| const workspaceBasename = app.workspace.path.split('/').pop(); | ||
| if (workspaceBasename) { | ||
| await app.page.getByText(workspaceBasename).click(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Should we maybe extract this into an own function that takes the app as a parameter to avoid repeating this code in several tests?
There was a problem hiding this comment.
Absolutely, I will adjust the PR!
xai
force-pushed
the
electron-playwright
branch
from
969c59e
to
754f50a
Compare
* Update theia dependency to 1.46.1 * Use new TheiaApploader * Add workaround for Electron playwright multi root issue * Support different projects (e.g., chromium or Electron) in performance reports * Remove dependency to deprecated xvfb-action Contributed on behalf of STMicroelectronics Signed-off-by: Olaf Lessenich <[email protected]>
xai
force-pushed
the
electron-playwright
branch
from
754f50a
to
f4e2ce0
Compare
planger
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The electron performance tests depend on Theia > 1.46.1 because they need to access the metrics endpoint.