Set resolution for eslint-plugin-deprecation plugin #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
Comment on lines
35
to
37
| "resolutions": { | ||
| "**/eslint-plugin-deprecation": "1.2.1" | ||
| }, |
There was a problem hiding this comment.
@jfaltermeier rather than add a resolution, why do we not simply update the dependency to use 1.2.1 directly?
to:
"eslint-plugin-deprecation": "1.2.1"There was a problem hiding this comment.
So usually I like resolution for issues like this because it also works for transient dependencies. I started with restricting typescript-eslint/experimental-utils which led me to eslint-plugin-deprecation.
But in this case we only have a direct dependency, so I'll update this
The recent update of eslint-plugin-deprecation pulls in a newer version of @typescript-eslint/experimental-utils. This version is not compatible with the node versions available on the shared windows and mac build nodes. (For Linux we could update the docker image): error @typescript-eslint/[email protected]: The engine "node" is incompatible with this module. Expected version "^12.22.0 || ^14.17.0 || >=16.0.0". Got "12.20.0" For now set eslint-plugin-deprecation to the version known to work.
jfaltermeier
force-pushed
the
jf/build-issues
branch
from
b790616 to
8436117
Compare
vince-fugnitto
approved these changes
Jan 7, 2022
There was a problem hiding this comment.
I confirmed that the change works, the build passes again and the application starts 👍
On master using node v12.18.3:
$ yarn
yarn install v1.22.4
[1/5] Validating package.json...
[2/5] Resolving packages...
[3/5] Fetching packages...
info [email protected]: The platform "linux" is incompatible with this module.
info "[email protected]" is an optional dependency and failed compatibility check. Excluding it from installation.
error @typescript-eslint/[email protected]: The engine "node" is incompatible with this module. Expected version "^12.22.0 || ^14.17.0 || >=16.0.0". Got "12.18.3"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The recent update of
eslint-plugin-deprecationpulls in a newer version of@typescript-eslint/experimental-utils.This version is not compatible with the node versions available on the shared windows and mac build nodes.
(For Linux we could update the docker image):
error @typescript-eslint/[email protected]: The engine "node" is incompatible with this module. Expected version "^12.22.0 || ^14.17.0 || >=16.0.0". Got "12.20.0"https://ci.eclipse.org/theia/job/Theia2/job/master/16/consoleText
For now set a resolution for
eslint-plugin-deprecationto the version known to work.How to test
Build with a node version lower than 12.22 and check whether the build succeeds
Review checklist
Reminder for reviewers