use file system path for copy commands (#12002)

eclipse-theia · Jan 13, 2023 · 2d08d88 · 2d08d88
1 parent 315f2e0
commit 2d08d88
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/packages/core/src/browser/common-frontend-contribution.ts b/packages/core/src/browser/common-frontend-contribution.ts
@@ -737,7 +737,7 @@ export class CommonFrontendContribution implements FrontendApplicationContributi
             execute: async uris => {
                 if (uris.length) {
                     const lineDelimiter = isWindows ? '\r\n' : '\n';
-                    const text = uris.map(resource => resource.path).join(lineDelimiter);
+                    const text = uris.map(resource => resource.path.fsPath()).join(lineDelimiter);
                     await this.clipboardService.writeText(text);
                 } else {
                     await this.messageService.info('Open a file first to copy its path');

diff --git a/packages/workspace/src/browser/workspace-commands.ts b/packages/workspace/src/browser/workspace-commands.ts
@@ -316,9 +316,9 @@ export class WorkspaceCommandContribution implements CommandContribution {
                 const text = uris.map((uri: URI) => {
                     const workspaceRoot = this.workspaceService.getWorkspaceRootUri(uri);
                     if (workspaceRoot) {
-                        return workspaceRoot.relative(uri);
+                        return workspaceRoot.relative(uri)?.fsPath();
                     } else {
-                        return uri.path;
+                        return uri.path.fsPath();
                     }
                 }).join(lineDelimiter);
                 await this.clipboardService.writeText(text);
@@ -425,7 +425,7 @@ export class WorkspaceCommandContribution implements CommandContribution {
 
     protected trimFileName(name: string): string {
         if (name && name.length > 30) {
-            return `${name.substr(0, 30)}...`;
+            return `${name.substring(0, 30)}...`;
         }
         return name;
     }