Skip to content

Commit

Permalink
Fix linter problems
Browse files Browse the repository at this point in the history
Signed-off-by: Thomas Mäder <[email protected]>
  • Loading branch information
tsmaeder committed May 20, 2024
1 parent 59c4bfd commit 427e2da
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 5 deletions.
5 changes: 3 additions & 2 deletions examples/playwright/src/theia-app.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,8 @@ export class TheiaApp {
return view;
}

async openEditor<T extends TheiaEditor>(filePath: string, editorFactory: { new(filePath: string, app: TheiaApp): T },
async openEditor<T extends TheiaEditor>(filePath: string,
editorFactory: { new(fp: string, app: TheiaApp): T },
editorName?: string, expectFileNodes = true): Promise<T> {
const explorer = await this.openView(TheiaExplorerView);
if (!explorer) {
Expand Down Expand Up @@ -135,7 +136,7 @@ export class TheiaApp {
return editor;
}

async activateExistingEditor<T extends TheiaEditor>(filePath: string, editorFactory: { new(filePath: string, app: TheiaApp): T }): Promise<T> {
async activateExistingEditor<T extends TheiaEditor>(filePath: string, editorFactory: { new(fp: string, app: TheiaApp): T }): Promise<T> {
const editor = new editorFactory(filePath, this);
if (!await editor.isTabVisible()) {
throw new Error(`Could not find opened editor for file ${filePath}`);
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/common/encoding-service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ export class EncodingService {
});
}

encodeStream(value: string | Readable<string>, options?: ResourceEncoding): Promise<BinaryBuffer | BinaryBufferReadable>
encodeStream(value: string | Readable<string>, options?: ResourceEncoding): Promise<BinaryBuffer | BinaryBufferReadable>;
encodeStream(value?: string | Readable<string>, options?: ResourceEncoding): Promise<BinaryBuffer | BinaryBufferReadable | undefined>;
async encodeStream(value: string | Readable<string> | undefined, options?: ResourceEncoding): Promise<BinaryBuffer | BinaryBufferReadable | undefined> {
let encoding = options?.encoding;
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin-ext/src/main/browser/quick-open-main.ts
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ export class QuickOpenMainImpl implements QuickOpenMain, Disposable {
}

private toQuickPickItem(item: undefined): undefined;
private toQuickPickItem(item: TransferQuickPickItem): QuickPickItem
private toQuickPickItem(item: TransferQuickPickItem): QuickPickItem;
private toQuickPickItem(item: TransferQuickPickItem | undefined): QuickPickItem | undefined {
if (!item) {
return undefined;
Expand Down
2 changes: 1 addition & 1 deletion packages/plugin/src/theia.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7910,7 +7910,7 @@ export module '@theia/plugin' {
* @param pattern A file glob pattern like `*.{ts,js}` that will be matched on file paths
* relative to the base path.
*/
constructor(base: WorkspaceFolder | Uri | string, pattern: string)
constructor(base: WorkspaceFolder | Uri | string, pattern: string);
}

/**
Expand Down

0 comments on commit 427e2da

Please sign in to comment.