Skip to content

Commit

Permalink
apply suggestions
Browse files Browse the repository at this point in the history
  • Loading branch information
Alberto Iannaccone committed Aug 11, 2022
1 parent 992fa84 commit 6044ff3
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 11 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

import * as express from 'express';
import { inject, injectable } from 'inversify';
import { Deferred } from 'src/common/promise-util';
import { Deferred } from '../../common/promise-util';
import { BackendApplicationContribution } from '../backend-application';
import { LocalizationRegistry } from './localization-contribution';
import { LocalizationProvider } from './localization-provider';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ import { PluginTheiaEnvironment } from '../common/plugin-theia-environment';
import { PluginTheiaDeployerParticipant } from './plugin-theia-deployer-participant';
import { WebviewBackendSecurityWarnings } from './webview-backend-security-warnings';
import { PluginUninstallationManager } from './plugin-uninstallation-manager';
import { LocalizationBackendContribution } from '@theia/core/src/node/i18n/localization-backend-contribution';
import { LocalizationBackendContribution } from '@theia/core/lib/node/i18n/localization-backend-contribution';
import { PluginLocalizationBackendContribution } from './plugin-localization-backend-contribution';

export function bindMainBackend(bind: interfaces.Bind, unbind: interfaces.Unbind, isBound: interfaces.IsBound, rebind: interfaces.Rebind): void {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,21 +1,26 @@
import { inject, injectable } from '@theia/core/shared/inversify';
import { LocalizationBackendContribution } from '@theia/core/lib/node/i18n/localization-backend-contribution';
import { PluginDeployer } from '../../common/plugin-protocol';
import { PluginDeployerImpl } from './plugin-deployer-impl';
import { Deferred } from '@theia/core/src/common/promise-util';
import { inject, injectable } from "@theia/core/shared/inversify";
import { LocalizationBackendContribution } from "@theia/core/lib/node/i18n/localization-backend-contribution";
import { PluginDeployer } from "../../common/plugin-protocol";
import { PluginDeployerImpl } from "./plugin-deployer-impl";
import { Deferred } from "@theia/core/lib/common/promise-util";

@injectable()
export class PluginLocalizationBackendContribution extends LocalizationBackendContribution {
@inject(PluginDeployer)
protected readonly pluginDeployer: PluginDeployerImpl;
protected readonly pluginsDeployed = new Deferred();

override async initialize(): Promise<void> {
const pluginsDeployed = new Deferred();
this.pluginDeployer.onDidDeploy(() => {
pluginsDeployed.resolve();
this.pluginsDeployed.resolve();
});
await super.initialize();
}

await Promise.all([this.localizationRegistry.initialize(), pluginsDeployed.promise]);
this.initialized.resolve();
override async waitForInitialization(): Promise<void> {
await Promise.all([
super.waitForInitialization(),
this.pluginsDeployed.promise,
]);
}
}

0 comments on commit 6044ff3

Please sign in to comment.