Skip to content

Commit

Permalink
fix: try with exact version 28.2.8 like in VS Code
Browse files Browse the repository at this point in the history
The Electron tests are failing on Ubuntu in the GH Action. Trying
different things to fix.
  • Loading branch information
sdirix committed Apr 10, 2024
1 parent fb73e8e commit 8686dd1
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion examples/electron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,6 @@
},
"devDependencies": {
"@theia/cli": "1.48.0",
"electron": "^28.2.8"
"electron": "28.2.8"
}
}
2 changes: 1 addition & 1 deletion packages/core/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class SomeClass {

- `@theia/core/electron-shared/...`
- `native-keymap` (from [`native-keymap@^2.2.1`](https://www.npmjs.com/package/native-keymap))
- `electron` (from [`electron@^28.2.8`](https://www.npmjs.com/package/electron))
- `electron` (from [`[email protected]`](https://www.npmjs.com/package/electron/v/28.2.8))
- `electron-store` (from [`electron-store@^8.0.0`](https://www.npmjs.com/package/electron-store))
- `fix-path` (from [`fix-path@^3.0.0`](https://www.npmjs.com/package/fix-path))
- `@theia/core/shared/...`
Expand Down
2 changes: 1 addition & 1 deletion packages/electron/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ The `@theia/electron` extension bundles all Electron-specific dependencies and c

- `@theia/electron/shared/...`
- `native-keymap` (from [`native-keymap@^2.2.1`](https://www.npmjs.com/package/native-keymap))
- `electron` (from [`electron@^28.2.8`](https://www.npmjs.com/package/electron))
- `electron` (from [`[email protected]`](https://www.npmjs.com/package/electron/v/28.2.8))
- `electron-store` (from [`electron-store@^8.0.0`](https://www.npmjs.com/package/electron-store))
- `fix-path` (from [`fix-path@^3.0.0`](https://www.npmjs.com/package/fix-path))

Expand Down
2 changes: 1 addition & 1 deletion packages/electron/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
"@theia/re-exports": "1.48.0"
},
"peerDependencies": {
"electron": "^28.2.8"
"electron": "28.2.8"
},
"theiaReExports": {
"shared": {
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -4953,10 +4953,10 @@ electron-window@^0.8.0:
dependencies:
is-electron-renderer "^2.0.0"

electron@^28.2.8:
version "28.2.10"
resolved "https://registry.yarnpkg.com/electron/-/electron-28.2.10.tgz#4e168568406a8b1e9b9a5859e988c905b9a57570"
integrity sha512-0rGBJNogcl2FIRxGRUv9zuMaBP78nSBJW+Bd1U7OGeg8IEkSIbHOhfn71XoGxgbOUSCEXjjyftq4mtAAVbUsZQ==
[email protected]:
version "28.2.8"
resolved "https://registry.yarnpkg.com/electron/-/electron-28.2.8.tgz#b83d70ca00c0e767f0125fcec85f39aafe39ee4c"
integrity sha512-VgXw2OHqPJkobIC7X9eWh3atptjnELaP+zlbF9Oz00ridlaOWmtLPsp6OaXbLw35URpMr0iYesq8okKp7S0k+g==
dependencies:
"@electron/get" "^2.0.0"
"@types/node" "^18.11.18"
Expand Down

0 comments on commit 8686dd1

Please sign in to comment.