Skip to content

Commit

Permalink
Rebase on master and include review comments
Browse files Browse the repository at this point in the history
  • Loading branch information
eneufeld committed May 20, 2022
1 parent 8b44ffe commit af88af0
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 7 deletions.
7 changes: 1 addition & 6 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,17 +3,12 @@
## History

- [Previous Changelogs](https://github.com/eclipse-theia/theia/tree/master/doc/changelogs/)
## v1.25.0 - 4/28/2022
[1.25.0 Milestone](https://github.com/eclipse-theia/theia/milestone/33)

- [plugin] added support for `ExtensionMode` [#10201](https://github.com/eclipse-theia/theia/pull/10201) - Contributed on behalf of STMicroelectronics



## v.1.26.0

- [plugin] Introduce `DebugSession#workspaceFolder` [#11090](https://github.com/eclipse-theia/theia/pull/11090) - Contributed on behalf of STMicroelectronics
- [console] fixed issue in Debug console where console history was not being trimmed in accordance with the maximum commands limit [#10598](https://github.com/eclipse-theia/theia/pull/10598)
- [plugin] added support for `ExtensionMode` [#10201](https://github.com/eclipse-theia/theia/pull/10201) - Contributed on behalf of STMicroelectronics

<a name="breaking_changes_1.26.0">[Breaking Changes:](#breaking_changes_1.26.0)</a>

Expand Down
1 change: 1 addition & 0 deletions packages/plugin-dev/src/node/hosted-plugin-reader.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export class HostedPluginReader implements BackendApplicationContribution {
const pluginPath = process.env.HOSTED_PLUGIN;
if (pluginPath) {
const hostedPlugin = new PluginDeployerEntryImpl('Hosted Plugin', pluginPath!, pluginPath);
hostedPlugin.storeValue('isUnderDevelopment', true);
const hostedMetadata = await this.hostedPlugin.promise;
if (hostedMetadata!.model.entryPoint && hostedMetadata!.model.entryPoint.backend) {
this.deployerHandler.deployBackendPlugins([hostedPlugin]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ export class PluginDeployerEntryImpl implements PluginDeployerEntry {
} else {
this.resolved = false;
}
this.storeValue('isUnderDevelopment', originId === 'Hosted Plugin');
}

id(): string {
Expand Down

0 comments on commit af88af0

Please sign in to comment.