fix file-saving dialog

This commit fixes the issue where cancelling the file-saving dialog incorrectly closes the editor. Signed-off-by: Vlad Arama <[email protected]>
eclipse-theia · Aug 25, 2023 · b4e91d1 · b4e91d1
1 parent 628d6d2
commit b4e91d1
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/packages/core/src/browser/saveable.ts b/packages/core/src/browser/saveable.ts
@@ -125,8 +125,12 @@ export namespace Saveable {
                 if (typeof result === 'boolean') {
                     if (result) {
                         await (doSave?.(this) ?? Saveable.save(this));
+                        if (!isDirty(this)) {
+                            await this.closeWithoutSaving();
+                        }
+                    } else {
+                        await this.closeWithoutSaving();
                     }
-                    await this.closeWithoutSaving();
                 }
             } finally {
                 closing = false;