address review comments

eclipse-theia · Jul 23, 2024 · c633d7d · c633d7d
1 parent ade6c8d
commit c633d7d
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 2 deletions.
diff --git a/packages/debug/src/browser/debug-session.tsx b/packages/debug/src/browser/debug-session.tsx
@@ -259,7 +259,7 @@ export class DebugSession implements CompositeTreeElement {
         return this._currentThread;
     }
     set currentThread(thread: DebugThread | undefined) {
-        if (this._currentThread === thread) {
+        if (this._currentThread?.id === thread?.id) {
             return;
         }
         this.toDisposeOnCurrentThread.dispose();

diff --git a/packages/debug/src/browser/model/debug-thread.tsx b/packages/debug/src/browser/model/debug-thread.tsx
@@ -65,7 +65,7 @@ export class DebugThread extends DebugThreadData implements TreeElement {
         return this._currentFrame;
     }
     set currentFrame(frame: DebugStackFrame | undefined) {
-        if (this._currentFrame === frame) {
+        if (this._currentFrame?.id === frame?.id) {
             return;
         }
         this._currentFrame = frame;

diff --git a/packages/plugin-ext/src/plugin/debug/debug-ext.ts b/packages/plugin-ext/src/plugin/debug/debug-ext.ts
@@ -270,6 +270,9 @@ export class DebugExtImpl implements DebugExt {
     }
 
     set activeStackItem(stackItem: theia.DebugStackFrame | theia.DebugThread | undefined) {
+        if (this._activeStackItem === stackItem) {
+            return;
+        }
         this._activeStackItem = stackItem;
         this.onDidChangeActiveStackItemEmitter.fire(this.activeStackItem);
     }