Skip to content

Commit

Permalink
playwright: cleanup build process (#12248)
Browse files Browse the repository at this point in the history
The commit updates the `@theia/playwright` package to not install it's dependencies on startup
since we often do not run the tests manually but instead handles the package similarly to our examples where
they can built on demand. The change should improve the build process without irrelevant logs.

Signed-off-by: vince-fugnitto <[email protected]>
  • Loading branch information
vince-fugnitto authored Mar 13, 2023
1 parent 4e40790 commit de3fc72
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 2 deletions.
7 changes: 6 additions & 1 deletion .github/workflows/playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
with:
python-version: "3.x"

- name: Build
- name: Build Browser
shell: bash
run: |
yarn --skip-integrity-check --network-timeout 100000
Expand All @@ -42,6 +42,11 @@ jobs:
NODE_OPTIONS: --max_old_space_size=4096
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} # https://github.com/microsoft/vscode-ripgrep/issues/9

- name: Build Playwright
shell: bash
run: |
yarn --cwd examples/playwright build
- name: Test (playwright)
uses: GabrielBB/xvfb-action@v1
with:
Expand Down
1 change: 1 addition & 0 deletions examples/playwright/docs/DEVELOPING.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
## Building

Run `yarn` in the root directory of the repository.
In order to build Playwright and install dependencies (ex: chromium) run `yarn --cwd examples/playwright` at the root of the repository.

## Executing the tests

Expand Down
1 change: 0 additions & 1 deletion examples/playwright/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
},
"homepage": "https://github.com/eclipse-theia/theia",
"scripts": {
"prepare": "yarn clean && yarn build",
"clean": "rimraf lib *.tsbuildinfo",
"build": "tsc --incremental && npx playwright install chromium",
"theia:start": "rimraf .tmp.cfg && THEIA_CONFIG_DIR=$PWD/.tmp.cfg yarn --cwd ../browser start",
Expand Down

0 comments on commit de3fc72

Please sign in to comment.