Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nls: missing or incorrect localizations #11040

Closed
vince-fugnitto opened this issue Apr 19, 2022 · 1 comment · Fixed by #11042
Closed

nls: missing or incorrect localizations #11040

vince-fugnitto opened this issue Apr 19, 2022 · 1 comment · Fixed by #11042
Labels
localization issues related to localization/internalization/nls

Comments

@vince-fugnitto
Copy link
Member

Bug Description:

I noticed in a couple of instances that localizations are incorrect, either casing or simply completely missing despite being part of vscode-loc.

Steps to Reproduce:

  1. start the application
  2. install the french language pack
  3. execute the command configure display language, and select fr (french)
  4. restart the application using the prompt
  5. on restart notice that the file (fichier) menu is not capitalized, and notice that submenu items are missing such as open file...
@vince-fugnitto vince-fugnitto added the localization issues related to localization/internalization/nls label Apr 19, 2022
@msujew
Copy link
Member

msujew commented Apr 19, 2022

I believe the file/fichier issue is a consequence of #10946, where I've normalized all strings so that the translations are independent of any capitalization. We should probably use a more "fail-safe" approach there.

Regarding Open file...: It seems like I forgot to add the nls.localizeByDefault call :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants