Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default translations with incorrect case #11042

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Fix default translations with incorrect case #11042

merged 1 commit into from
Apr 20, 2022

Conversation

msujew
Copy link
Member

@msujew msujew commented Apr 19, 2022

What it does

Closes #11040

How to test

  1. Follow the reproduction steps from nls: missing or incorrect localizations #11040
  2. Assert that the menu entries File and Open File... are correctly localized

Review checklist

Reminder for reviewers

@msujew msujew added the localization issues related to localization/internalization/nls label Apr 19, 2022
vince-fugnitto
vince-fugnitto approved these changes Apr 19, 2022
View reviewed changes
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirm that the changes fix #11040 👍

@msujew msujew merged commit c70312f into master Apr 20, 2022
@msujew msujew deleted the msujew/fix-invalid-translations branch April 20, 2022 20:13
@github-actions github-actions bot added this to the 1.25.0 milestone Apr 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vince-fugnitto vince-fugnitto vince-fugnitto approved these changes

Assignees
No one assigned
Labels
localization issues related to localization/internalization/nls
Projects
None yet
Milestone
1.25.0
Development

Successfully merging this pull request may close these issues.

nls: missing or incorrect localizations
2 participants
@msujew @vince-fugnitto