Unintended recursive set of title

[emilhammarstedtst]

This line creates an unintended infinite recursion when trying to set title of a webview.

theia/packages/plugin-ext/src/plugin/webview-views.ts

Line 171 in 81dd3ba

this.title = value;

should use this._title when comparing and assigning within get/set function

[tsmaeder]

How do you provoke this? If this is indeed recursive, wouldn't the recursion stop at the second iteration because this.title !== value would return false?

[msujew]

@tsmaeder Since the getter of this.title accesses _title (which never changes) it doesn't stop at the second iteration. It should indeed lead to an infinite recursion.

[tsmaeder]

Ah, thanks. Property methods are a blessing and a curse.