-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VSCode extension FileSystemWatcher not working since 1.33.0 #12260
Labels
file-watchers
issues related to filesystem watchers - nsfw
vscode
issues related to VSCode compatibility
Comments
vince-fugnitto
added
vscode
issues related to VSCode compatibility
file-watchers
issues related to filesystem watchers - nsfw
labels
Mar 6, 2023
sgraband
added a commit
to eclipsesource/theia
that referenced
this issue
Mar 7, 2023
Fixed an issue with tracking the current `FileSystemEvents` in the `MainFileSystemEventService`. Before, the events were tracked in a global field which was intended to be cleaned after an `onDidFilesChanges()` update was sent to the proxy. This is problematic as we do not await sending the update. Thus, the global field will be cleaned before the update is even sent and therefore, file watching updates might get lost. This change ensures that a field of events is kept for each update. Note that simply awaiting the update to be sent is not enough. This would introduce race conditions as other parallel updates might clean the state of other updates before they are being sent. Fixes eclipse-theia#12260. Contributed on behalf of STMicroelectronics
tsmaeder
pushed a commit
that referenced
this issue
Mar 10, 2023
Fixed an issue with tracking the current `FileSystemEvents` in the `MainFileSystemEventService`. Before, the events were tracked in a global field which was intended to be cleaned after an `onDidFilesChanges()` update was sent to the proxy. This is problematic as we do not await sending the update. Thus, the global field will be cleaned before the update is even sent and therefore, file watching updates might get lost. This change ensures that a field of events is kept for each update. Note that simply awaiting the update to be sent is not enough. This would introduce race conditions as other parallel updates might clean the state of other updates before they are being sent. Fixes #12260. Contributed on behalf of STMicroelectronics
martin-fleck-at
added a commit
to CrossBreezeNL/crossmodel
that referenced
this issue
Mar 17, 2023
- Add support for 'package.json' files -- Listen to changes of 'package.json' files -- Add VS code plugins to support editing 'package.json' files - Add package manager for simple dependency management -- Do not build 'package.json' files (as they do not match CM grammar) -- Instead build up dependency graph based on package information -- Consider models under 'package.json' directory part of the package - Replace workspace-based scoping with package-based scoping -- Only models within the same models or dependent models are visible -- Ensure 'node_modules' directory is also scanned Minor: - Update to latest version of Langium - Convert model service to shared service -- Requires retrieval of serializer based on URI -- Extend language model service to ensure we have serializer - Fix eclipse-theia/theia#12260 locally TODO: - Requires reload after npm install (file watching issue?)
tsmaeder
pushed a commit
that referenced
this issue
Mar 20, 2023
Fixed an issue with tracking the current `FileSystemEvents` in the `MainFileSystemEventService`. Before, the events were tracked in a global field which was intended to be cleaned after an `onDidFilesChanges()` update was sent to the proxy. This is problematic as we do not await sending the update. Thus, the global field will be cleaned before the update is even sent and therefore, file watching updates might get lost. This change ensures that a field of events is kept for each update. Note that simply awaiting the update to be sent is not enough. This would introduce race conditions as other parallel updates might clean the state of other updates before they are being sent. Fixes #12260. Contributed on behalf of STMicroelectronics
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
file-watchers
issues related to filesystem watchers - nsfw
vscode
issues related to VSCode compatibility
Bug Description:
Extensions that use the
vscode.workspace.createFileSystemWatcher
function stopped working with Theia 1.33.0. I was able to narrow it down to this commit.Feel free to assign this ticket to me as i will investigate it and work on a fix.
Steps to Reproduce:
Additional Information
Test extension code:
Another extension that has the same problem is the eclipse-cdt-cloud clangd-context extension.
The text was updated successfully, but these errors were encountered: