-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[proposed API][builtins] Theia misses part of proposed API: EditSessionIdentityProvider #12521
Closed
Tracked by
#12518
Comments
marcdumais-work
added
git
issues related to git
vscode
issues related to VSCode compatibility
builtins
Issues related to VS Code builtin extensions
labels
May 11, 2023
marcdumais-work
changed the title
[proposed API][builtins] Theia misses proposed API: EditSessionIdentityProvider
[proposed API][builtins] Theia misses part of proposed API: EditSessionIdentityProvider
May 11, 2023
2 tasks
marcdumais-work
added a commit
that referenced
this issue
May 15, 2023
…tSessionIdentity This event has recently been added to vscode's version of this proposed API, along with an implementation that we will not have at this time. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
added a commit
that referenced
this issue
May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider. For now we go with a stub that will allow `[email protected]` and more recent to activate and be used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
added a commit
that referenced
this issue
May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `[email protected]` and more recent to activate and be successfully used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
1 task
marcdumais-work
added a commit
that referenced
this issue
May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `[email protected]` and more recent to activate and be successfully used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
added a commit
that referenced
this issue
May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `[email protected]` and more recent to activate and be successfully used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
added a commit
that referenced
this issue
May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `[email protected]` and more recent to activate and be successfully used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
added a commit
that referenced
this issue
May 15, 2023
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `[email protected]` and more recent to activate and be successfully used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
added a commit
that referenced
this issue
May 16, 2023
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `[email protected]` and more recent to activate and be successfully used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
added a commit
that referenced
this issue
May 18, 2023
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `[email protected]` and more recent to activate and be successfully used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
marcdumais-work
added a commit
that referenced
this issue
May 19, 2023
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `[email protected]` and more recent to activate and be successfully used in Theia applications. Fixes #12521 Signed-off-by: Marc Dumais <[email protected]>
tsmaeder
pushed a commit
to tsmaeder/theia
that referenced
this issue
May 23, 2023
This event was recently added to proposed API EditSessionIdentityProvider. For now we add a stub that will allow `[email protected]` and more recent to activate and be successfully used in Theia applications. Fixes eclipse-theia#12521 Signed-off-by: Marc Dumais <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Bug Description:
Or part thereof:
workspace.onWillCreateEditSessionIdentity
Discovered while testing locally-built vscode built-in extensions
1.77.0
, that resulted in a failed activation forvscode.git
.interesting part of the exception:
It looks like it's using a bit of proposed API: EditSessionIdentityProvider that we do not have yet.
Steps to Reproduce:
Use this extension after unzipping it into your
plugins
folder:git-1.77.0.zip
Additional Information
Full exception:
The text was updated successfully, but these errors were encountered: