Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement activeViewlet and Related Context Keys #12589

Closed
tsmaeder opened this issue Jun 1, 2023 · 2 comments · Fixed by #12597
Closed

Implement activeViewlet and Related Context Keys #12589

tsmaeder opened this issue Jun 1, 2023 · 2 comments · Fixed by #12597
Labels
vscode issues related to VSCode compatibility

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Jun 1, 2023

Feature Description:

Some when-clause context keys are unimplemented in Theia (see https://code.visualstudio.com/api/references/when-clause-contexts#visible-view-container-when-clause-context).

We have definitions of the context keys in view-context-key-service, and the values are referenced in some places, but there seems to be no place where the value is actually set.

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Jun 1, 2023
@tsmaeder
Copy link
Contributor Author

tsmaeder commented Jun 2, 2023

Actually, there is an implementation, except for activeAuxiliary (see plugin-view-registry.ts#updateVisibleView(...)). However, an adopter reports this does not always work. Investigating.

@tsmaeder
Copy link
Contributor Author

tsmaeder commented Jun 2, 2023

Further inquiry shows that the tracking only works for well known view container id's. For example, the activeViewlet === undefined when the plugin view is active instead of workbench.view.extensions. That means, of course, that view containers contributed by extensions don't work either.

tsmaeder added a commit to tsmaeder/theia that referenced this issue Jun 7, 2023
Track active top level widget and set the relevant context keys if the
visible widget is either well known or a contributed view container.

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder mentioned this issue Jun 7, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants