Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow multiple selection on Open... dialog #12905

Closed
rschnekenbu opened this issue Sep 14, 2023 · 1 comment · Fixed by #12923
Closed

Allow multiple selection on Open... dialog #12905

rschnekenbu opened this issue Sep 14, 2023 · 1 comment · Fixed by #12923
Assignees
Labels
dialogs issues related to dialogs

Comments

@rschnekenbu
Copy link
Contributor

Currently, multi selection is not supported for the Open... dialog. To open multiple files or multiple folders, the dialog has to be opened several times.
It would be nice to be able to select multiple files or multiple folders at once. In case of heterogeneous selection, i.e several files and folders at once, specific action to each kind should be performed (open file or open new workspace on folder)

@rschnekenbu
Copy link
Contributor Author

Can you please assign me this issue, I am working on it.

@vince-fugnitto vince-fugnitto added the dialogs issues related to dialogs label Sep 14, 2023
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 19, 2023
fixes eclipse-theia#12905

- allow multiple selection in doOpen dialog
- handle an array or a single URI or undefined when closing dialog

Contributed on behalf of ST Microelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 19, 2023
fixes eclipse-theia#12905

- allow multiple selection in doOpen dialog
- handle an array or a single URI or undefined when closing dialog

Contributed on behalf of ST Microelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 19, 2023
fixes eclipse-theia#12905

- allow multiple selection in doOpen dialog
- handle an array or a single URI or undefined when closing dialog

Contributed on behalf of ST Microelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu added a commit to eclipsesource/theia that referenced this issue Sep 28, 2023
fixes eclipse-theia#12905

- allow multiple selection in doOpen dialog
- handle an array or a single URI or undefined when closing dialog

Contributed on behalf of ST Microelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>

Address review comments

- remove checks for files against workspace URI
- update variable name to a more representative one
- Simplify algorithm for single selected URI case
- update signatures to indicate an array of files or folders can be opened rather than a single element
JonasHelming pushed a commit that referenced this issue Sep 28, 2023
fixes #12905

- allow multiple selection in doOpen dialog
- handle an array or a single URI or undefined when closing dialog

Contributed on behalf of ST Microelectronics

Signed-off-by: Remi Schnekenburger <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dialogs issues related to dialogs
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants