-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for adding new plugin api namespace needs updating #13067
Comments
So, with a little help from my friends, turns out the code above doesn't need adjusting. What does need adjusting is the build configuration. Specifically, in the electron app's
What that effectively does is puts a webpacked version of
No doubt, the same thing needs to be done for the frontend API initialization module, if you have one. |
I'll leave the ticket open as I do think it would be helpful for the markdown documentation to provide this additional insight. I wouldn't clutter that page up, though. I'd include a warning that the module specified for the API needs build-time special handling in the case of an app that uses a webpacked frontend/backend, and then provide a link to this ticket for the details? |
This markdown explains how a Theia app developer can add a new plugin API namespace. I followed it a while back and it's been working great.
However, recently, our Theia app was adjusted to consume the backend in webpacked form (something that became possible in Theia 1.40.1), and that broke the custom API namespace. Specifically, the way
backendInitPath
is set is now invalid:So, this ticket involves a question and an ask:
Question: how should I set
backendInitPath
so that it works in the backend-webpacked environmentAsk: would be nice for the markdown to be updated with this information so others don't trip on this
The text was updated successfully, but these errors were encountered: