Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuickPick buttons do not render #13076

Closed
SamuelBergSTM opened this issue Nov 14, 2023 · 6 comments · Fixed by #13342
Closed

QuickPick buttons do not render #13076

SamuelBergSTM opened this issue Nov 14, 2023 · 6 comments · Fixed by #13342
Labels
vscode issues related to VSCode compatibility
Milestone

Comments

@SamuelBergSTM
Copy link
Contributor

Bug Description:

QuickPick buttons do not render in Theia. They render as expected in VS Code.

Steps to Reproduce:

  1. Create a QuickPick with a button.
  2. Await to be able to keep QuickPick shown.
  3. Show the QuickPick.

Example:

const quickPick = vscode.window.createQuickPick();
quickPick.buttons = [vscode.QuickInputButtons.Back];

await new Promise<void>(resolve => {
    quickPick.onDidAccept(() => {
        resolve();
    });

    quickPick.show();
});

Additional Information

  • Operating System: Windows 10 Enterprise
  • Theia Version: 1.43.0

QuickPick with Back button in VS Code:

image

QuickPick with Back button in Theia:

image

@vince-fugnitto vince-fugnitto added the vscode issues related to VSCode compatibility label Nov 14, 2023
@tortmayr
Copy link
Contributor

I cannot reproduce this issue.
Using the example provided the back button is properly rendered in both 1.43.x and the current master (tested on Windows and Ubuntu).

@JonasHelming
Copy link
Contributor

@SamuelBergSTM : In order to reproduce this, could you maybe:
Provide a video or the exact steps (click here, hit these keys, etc.)
Provide a an example extensions (yo code makes this quite painless)
Provide browser and console logs (there might be an error)

@SamuelBergSTM
Copy link
Contributor Author

theia-13076.zip

@JonasHelming I attached a ZIP file including:

  1. demo.mkv: A video demonstrating how it is reproduced.
  2. steps.txt: Steps for creating the extension and reproducing the issue. Also includes versions of relevant software.
  3. logs: Frontend and backend logs.
  4. theia-13076-0.0.1.vsix: VSIX for the extension.
  5. theia-13076: Source files for the extension (excluding node_modules and out folders).

@tortmayr
Copy link
Contributor

tortmayr commented Jan 19, 2024

@SamuelBergSTM Thanks for the detailed instructions.
I will try to reproduce the issue and investigate a potential fix.

tortmayr added a commit to eclipsesource/theia that referenced this issue Feb 1, 2024
Ensure that  the Theia specific wrapper for the MonacoQuickPickItem properly forwards assignments of the "buttons" property to the wrapped item.

Fixes eclipse-theia#13076

Contributed on behalf of STMicroelectronics
@tortmayr
Copy link
Contributor

tortmayr commented Feb 1, 2024

@SamuelBergSTM This issue should be fixed with #13342

@SamuelBergSTM
Copy link
Contributor Author

@SamuelBergSTM This issue should be fixed with #13342

Perfect. Thanks.

tortmayr added a commit to eclipsesource/theia that referenced this issue Mar 8, 2024
Ensure that  the Theia specific wrapper for the MonacoQuickPickItem properly forwards assignments of the "buttons" property to the wrapped item.

Fixes eclipse-theia#13076

Contributed on behalf of STMicroelectronics
tortmayr added a commit that referenced this issue Mar 13, 2024
Ensure that  the Theia specific wrapper for the MonacoQuickPickItem properly forwards assignments of the "buttons" property to the wrapped item.

Fixes #13076

Contributed on behalf of STMicroelectronics
jonah-iden pushed a commit that referenced this issue Mar 15, 2024
Ensure that  the Theia specific wrapper for the MonacoQuickPickItem properly forwards assignments of the "buttons" property to the wrapped item.

Fixes #13076

Contributed on behalf of STMicroelectronics
jonah-iden added a commit that referenced this issue Mar 22, 2024
* basics for dev-container support

Signed-off-by: Jonah Iden <[email protected]>

* basic creating and connecting to container working

Signed-off-by: Jonah Iden <[email protected]>

* open workspace when opening container

Signed-off-by: Jonah Iden <[email protected]>

* save and reuse last USed container per workspace

Signed-off-by: Jonah Iden <[email protected]>

* restart container if running

Signed-off-by: Jonah Iden <[email protected]>

* better container creation extension features

Signed-off-by: Jonah Iden <[email protected]>

* added dockerfile support

Signed-off-by: Jonah Iden <[email protected]>

* rebuild container if devcontainer.json has been changed since last use

Signed-off-by: Jonah Iden <[email protected]>

* fix build

Signed-off-by: Jonah Iden <[email protected]>

* fixed checking if container needs rebuild

Signed-off-by: Jonah Iden <[email protected]>

* working port forwarding via exec instance

Signed-off-by: Jonah Iden <[email protected]>

* review changes

Signed-off-by: Jonah Iden <[email protected]>

* fix import

Signed-off-by: Jonah Iden <[email protected]>

* smaller fixes and added support for multiple devcontainer configuration files

Signed-off-by: Jonah Iden <[email protected]>

* basic output window for devcontainer build

Signed-off-by: Jonah Iden <[email protected]>

* smaller review changes and nicer dockerfile.json detection code

Signed-off-by: Jonah Iden <[email protected]>

* fixed build and docuemented implemented devcontainer.json properties

Signed-off-by: Jonah Iden <[email protected]>

* Fix unneeded URI conversion (#13415)

* Fix quickpick problems found in IDE testing (#13451)

Fixes #13450, #13449

contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>

* Fix rending of quickpick buttons (#13342)

Ensure that  the Theia specific wrapper for the MonacoQuickPickItem properly forwards assignments of the "buttons" property to the wrapped item.

Fixes #13076

Contributed on behalf of STMicroelectronics

* electron: allow accessing the metrics endpoint for performance analysis (#13380)

By default, when running Theia in Electron, all endpoints are protected
by the ElectronTokenValidator.
This patch allows accessing the '/metrics' endpoint without a token,
which enables us to collect metrics for performance analysis.

For this, ElectronTokenValidator is extended to allow access to the
metrics endpoint. All other endpoints are still protected.

Contributed on behalf of STMicroelectronics

Signed-off-by: Olaf Lessenich <[email protected]>

* fixed renaming and moving of open notebooks (#13467)

* fixed renameing of open notebooks

Signed-off-by: Jonah Iden <[email protected]>

* fixed moving of notebook editors to other areas

Signed-off-by: Jonah Iden <[email protected]>

---------

Signed-off-by: Jonah Iden <[email protected]>

* [playwright] Update documentation

Since a recent enhancement/refactoring of @theia/playwright, to permit using it in Theia
Electron applications, the way to load an application has changed. This commit is an
attempt to update the examples that are part of the documentation. I validated the changes
in the "theia-playwright-template" repository, and so I have adapted the sample code to
that repo's linting rules (using single quotes instead of double).

It's possible that other things have changed, that I have not yet encountered, but this
should be a good step forward, at least for those just getting started integrating
playwright to test their Theia-based app.

Signed-off-by: Marc Dumais <[email protected]>

* basics for dev-container support

Signed-off-by: Jonah Iden <[email protected]>

* basic creating and connecting to container working

Signed-off-by: Jonah Iden <[email protected]>

* added dockerfile support

Signed-off-by: Jonah Iden <[email protected]>

* added port forwarding inlcuding ui

Signed-off-by: Jonah Iden <[email protected]>

* basic port/address validation

Signed-off-by: Jonah Iden <[email protected]>

* fixed allready forwarded port checking

Signed-off-by: Jonah Iden <[email protected]>

* rebase  fixes

Signed-off-by: Jonah Iden <[email protected]>

* removed unused file

Signed-off-by: Jonah Iden <[email protected]>

* review changes

Signed-off-by: Jonah Iden <[email protected]>

* fixed widget focus and message margin

Signed-off-by: Jonah Iden <[email protected]>

* default port binding now shows as 0.0.0.0

Signed-off-by: Jonah Iden <[email protected]>

---------

Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Olaf Lessenich <[email protected]>
Signed-off-by: Marc Dumais <[email protected]>
Co-authored-by: Alexander Taran <[email protected]>
Co-authored-by: Thomas Mäder <[email protected]>
Co-authored-by: Tobias Ortmayr <[email protected]>
Co-authored-by: Olaf Lessenich <[email protected]>
Co-authored-by: Marc Dumais <[email protected]>
@jfaltermeier jfaltermeier added this to the 1.48.0 milestone Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants