Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vscode] WorkspaceEdit.set can now contain undefined Metadata with 1.86 #13355

Closed
Tracked by #13356
rschnekenbu opened this issue Feb 6, 2024 · 0 comments · Fixed by #13395
Closed
Tracked by #13356

[vscode] WorkspaceEdit.set can now contain undefined Metadata with 1.86 #13355

rschnekenbu opened this issue Feb 6, 2024 · 0 comments · Fixed by #13395
Assignees
@tsmaeder
Labels
vscode issues related to VSCode compatibility
Milestone
1.47.0

Comments

@rschnekenbu
Copy link
Contributor

rschnekenbu commented Feb 6, 2024 •
edited
Loading

update in the signature of
WorkspaceEdit.set(uri: Uri, edits: ReadonlyArray<[TextEdit | SnippetTextEdit, WorkspaceEditEntryMetadata | undefined]>): void;
and
WorkspaceEdit.set(uri: Uri, edits: ReadonlyArray<[NotebookEdit, WorkspaceEditEntryMetadata | undefined]>): void;

see https://github.com/microsoft/vscode/blob/4e52791d3e2ecd20247ee5c774f0fa533299f369/src/vscode-dts/vscode.d.ts#L3955
@rschnekenbu rschnekenbu mentioned this issue Feb 6, 2024
Closed
7 tasks
@rschnekenbu rschnekenbu added the vscode issues related to VSCode compatibility label Feb 6, 2024
@tsmaeder tsmaeder self-assigned this Feb 17, 2024
tsmaeder added a commit to tsmaeder/theia that referenced this issue Feb 17, 2024
@tsmaeder
Update WorkspaceEdit metadata typing
c6b67fe 
Fixes eclipse-theia#13355

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder mentioned this issue Feb 17, 2024
Merged
1 task
tsmaeder added a commit that referenced this issue Feb 20, 2024
@tsmaeder
Update WorkspaceEdit metadata typing (#13395)
384557b 
Fixes #13355

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@jfaltermeier jfaltermeier added this to the 1.47.0 milestone Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tsmaeder tsmaeder

Labels
vscode issues related to VSCode compatibility
Projects
None yet
Milestone
1.47.0
Development

Successfully merging a pull request may close this issue.

Update WorkspaceEdit metadata typing tsmaeder/theia
3 participants
@rschnekenbu @jfaltermeier @tsmaeder