Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Theia work on NodeJS 22.x #14026

Closed
1 task done
Tracked by #14027
tsmaeder opened this issue Aug 8, 2024 · 2 comments · Fixed by #14677
Closed
1 task done
Tracked by #14027

Make Theia work on NodeJS 22.x #14026

tsmaeder opened this issue Aug 8, 2024 · 2 comments · Fixed by #14677
Milestone
1.58.0

Comments

@tsmaeder
Copy link
Contributor

tsmaeder commented Aug 8, 2024

Feature Description:

Currently, Theia does not build against Node 22.x, there are build errors when building native packages, for example nswf.

prerequisites:
@tsmaeder tsmaeder mentioned this issue Aug 8, 2024
Merged
2 tasks
@msujew msujew mentioned this issue Sep 23, 2024
Closed
@JonasHelming
Copy link
Contributor

@tsmaeder Is this done now that the prerequisite is done?

@tsmaeder
Copy link
Contributor Author

After an update of node-pty to the latest beta version (1.1.0-beta27), Theia builds. Since node-pty is used for our whole process support, this needs serious testing, though.

tsmaeder added a commit to tsmaeder/theia that referenced this issue Dec 27, 2024
@tsmaeder
Update node-pty to 1.1.0-beta27
7230846 
Fixes eclipse-theia#14026

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder mentioned this issue Dec 27, 2024
Merged
2 tasks
tsmaeder added a commit that referenced this issue Jan 6, 2025
@tsmaeder
Update node-pty to 1.1.0-beta27 (#14677)
202ab63 
Fixes #14026

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
@jfaltermeier jfaltermeier added this to the 1.58.0 milestone Jan 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.58.0
Development

Successfully merging a pull request may close this issue.

Update node-pty to 1.1.0-beta27 tsmaeder/theia
3 participants
@JonasHelming @jfaltermeier @tsmaeder