Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Plugin API] Update the DecorationProvider API with vscode changes #8623

Open
vinokurig opened this issue Oct 13, 2020 · 0 comments
Open

[Plugin API] Update the DecorationProvider API with vscode changes #8623

vinokurig opened this issue Oct 13, 2020 · 0 comments
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility

Comments

@vinokurig
Copy link
Contributor

The DecorationProvider was moved to public API: microsoft/vscode#54938
Need to apply changes from vscode to theia's plugin API:

theia/packages/plugin/src/theia-proposed.d.ts

Lines 249 to 252 in e7a0160

export interface DecorationProvider {
onDidChangeDecorations: Event<undefined | Uri | Uri[]>;
provideDecoration(uri: Uri, token: CancellationToken): ProviderResult<DecorationData>;
}

The decoration provider is used in the latest (1.5.0) built-in vscode git plugin.

Feature Description:
@vinokurig vinokurig added plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility labels Oct 13, 2020
@benoitf benoitf mentioned this issue Oct 22, 2020
Merged
@ericwill ericwill mentioned this issue Oct 22, 2020
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plug-in system issues related to the plug-in system vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vinokurig