-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support "editor/title/run" toolbar commands #9387
Labels
debug
issues that related to debug functionality
help wanted
issues meant to be picked up, require help
toolbar
issues related to the toolbar
vscode
issues related to VSCode compatibility
Comments
1 task
Would very much love to see this implemented. Extensions like Code Runner greatly improve UX using the run menu. |
rschnekenbu
added a commit
to eclipsesource/theia
that referenced
this issue
Jun 12, 2023
Closes: eclipse-theia#9387 The commit adds the "editor/title/run" contribution point to menus Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
2 tasks
rschnekenbu
added a commit
to eclipsesource/theia
that referenced
this issue
Jun 21, 2023
Closes: eclipse-theia#9387 The commit adds the "editor/title/run" contribution point to menus Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
2 tasks
rschnekenbu
added a commit
to eclipsesource/theia
that referenced
this issue
Jun 21, 2023
Closes: eclipse-theia#9387 The commit adds the "editor/title/run" contribution point to menus Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
rschnekenbu
added a commit
to eclipsesource/theia
that referenced
this issue
Jun 22, 2023
Closes: eclipse-theia#9387 The commit adds the "editor/title/run" contribution point to menus Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
JonasHelming
pushed a commit
that referenced
this issue
Jun 27, 2023
Closes: #9387 The commit adds the "editor/title/run" contribution point to menus Contributed on behalf of STMicroelectronics Signed-off-by: Remi Schnekenburger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
debug
issues that related to debug functionality
help wanted
issues meant to be picked up, require help
toolbar
issues related to the toolbar
vscode
issues related to VSCode compatibility
VS Code added a new contribution for editor toolbar icons: "editor/title/run" and encouraged extensions to move their Run/Debug icons to them:
microsoft/vscode@97c7d2a
https://code.visualstudio.com/updates/v1_54#_limits-for-editor-title-menu-and-run-submenu:~:text=added%20the%20editor%2Ftitle%2Frun%20submenu
As a consequence, these buttons have disappeared from Theia, as it doesn't read commands from there.
Pushing them onto the front of
editor/title
commands may be an easy fix to support them, though VS Code goes a little further and collapses them into a single button with a drop-down menu:Example definition: https://github.com/Dart-Code/Dart-Code/blob/393763bc887dce42953646e3ea7381060beefd93/package.json#L1059-L1071
The text was updated successfully, but these errors were encountered: