Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken link in keymaps package README.md #9927

Closed
JonasHelming opened this issue Aug 18, 2021 · 0 comments · Fixed by #9929
Closed

Broken link in keymaps package README.md #9927

JonasHelming opened this issue Aug 18, 2021 · 0 comments · Fixed by #9929
Labels
documentation issues related to documentation keybindings issues related to keybindings

Comments

@JonasHelming
Copy link
Contributor

Bug Description:

The link to keys.ts in
https://github.com/eclipse-theia/theia/blob/7d3b1d3b33cb565ec07965e5baf10c926006cdfd/packages/keymaps/README.md?_pjax=%23repo-content-pjax-container#supported-keys
is broken, keys.ts has been moved. I will fix this.
JonasHelming added a commit that referenced this issue Aug 18, 2021
@JonasHelming
Fixed broken link in README
3015c93 
fixed #9927

Signed-off-by: Jonas Helming <[email protected]>
@JonasHelming JonasHelming mentioned this issue Aug 18, 2021
Merged
1 task
@vince-fugnitto vince-fugnitto added documentation issues related to documentation keybindings issues related to keybindings labels Aug 18, 2021
JonasHelming added a commit that referenced this issue Aug 18, 2021
@JonasHelming
Fixed broken link in README
e975871 
fixed #9927

Signed-off-by: Jonas Helming <[email protected]>
vince-fugnitto pushed a commit that referenced this issue Aug 18, 2021
@JonasHelming
keymaps: fix broken link in readme (#9929)
a6422c3 
Fixes: #9927

The commit fixes a broken link in the `@theia/keymaps` readme.
The fix includes updating the link to point to our documentation site which is not subject to change as frequently as referencing code directly.

Signed-off-by: Jonas Helming <[email protected]>
dna2github pushed a commit to dna2fork/theia that referenced this issue Aug 25, 2021
@JonasHelming @dna2github
keymaps: fix broken link in readme (eclipse-theia#9929)
28b115e 
Fixes: eclipse-theia#9927

The commit fixes a broken link in the `@theia/keymaps` readme.
The fix includes updating the link to point to our documentation site which is not subject to change as frequently as referencing code directly.

Signed-off-by: Jonas Helming <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation issues related to documentation keybindings issues related to keybindings
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed broken link in README eclipse-theia/theia
2 participants
@JonasHelming @vince-fugnitto