-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add localization extraction to Theia CLI #10247
Conversation
720edfb
to
c195d41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know enough knowledge in Typescript to review the code I think but all in all looks good.
In any case I tested the new command with arduino/arduino-ide and it works great. The json is created as expected and in case of failures the errors are clear and meaningful.
For what it's worth am approving this. 👍
Thanks @msujew! 🙏
c195d41
to
4b5679c
Compare
4b5679c
to
c278672
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works exactly as described.
c278672
to
eb09f31
Compare
eb09f31
to
42cba45
Compare
@vince-fugnitto Just to make sure, there's nothing that stops me from merging this PR, right? |
@msujew I'll give it a quick review if that's alright? :) |
@vince-fugnitto Please do so :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@msujew I confirmed that:
- the source code changes look good
- the different steps in 'how to reproduce' work well
LGTM! 👍
What it does
Adds an additional CLI command to the Theia-CLI that allows users to extract their localization keys and default values into a json file. This file can later be used to create translations for Theia using different services (e.g. the default mechanism proposed in #10187).
How to test
yarn theia extract -p "**/*.ts" -o out.json
Review checklist
Reminder for reviewers