Handle Language Overrides in setPreference
#10665
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #10663 by checking whether the preference name passed to
setPreference
contains a language override identifier and handling that case appropriately.How to test
.theia/settings.json
), if you'd like.Overrides: Set language overrides
settings.json
and those settings should take effect in the TS file.
7. Run the command
Overrides: Remove tabsize override
8. It should remove
"editor.tabSize"
from the[typescript]
object in thesettings.json
, and you should get the defaulttabSize
in your TS file.9. Run the command
Overrides: Remove Typescript overrides
.10. It should delete the
[typescript]
section entirely, and you should get default behavior for both preferences.11. If the tests in this PR pass, it shows basically the same thing as those steps do manually.
Review checklist
Reminder for reviewers