fix: fix eslint-plugin runtime import check rule

[ohmyide]

What it does

fix eslint-plugin runtime import check rule

How to test

run: yarn lint

case:
in a common folder like: src/common/**.ts ，the rule only matched /browser/, unmatched /browser;：

import { FrontendApplicationContribution } from '@theia/core/lib/browser'; 

if (matchedImportRule.restricted.some(restricted => module.includes(/${restricted}/))) {

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: ohmyide [email protected]

[vince-fugnitto]

Thank you for your contribution @ohmyide 👍

In order to accept your changes please be sure to sure to sign the eclipse contributor agreement (eca) with the same email as your authorship.

---

Can you describe a use-case that the rule fails today, it was not clear in your description.

[vince-fugnitto]

The changes look good, it looks like you were able to identify another issue in the codebase.
We will need to suppress it for the time being so we can then fix it (error).

You can suppress it like other instances, using:

packages/plugin-ext/src/common/plugin-api-rpc.ts

// eslint-disable-next-line @theia/runtime-import-check
import { PickOptions, QuickInputButtonHandle, QuickPickItem, WidgetOpenerOptions } from '@theia/core/lib/browser';

[ohmyide]

Sorry, I am late.

we knows that: common dir only can import common file, the runtime-import-check can help us find the error import.
But The rule in the source code only matched /browser/, in the case like: /browser , it can't matched (it is not end of /).

in my project:

The '@theia/core/lib/browser' can't import in common dir, runtime-import-check should find it, and give me a lint error, but it does not work, because it is not end of '/browser/'.

I think it's a rule mistake, so I try to fix it.

I'm not good at English, I don't know if I made it clear.

[vince-fugnitto]

@ohmyide I understand the fix :) I confirmed that it works and you actually helped identify an issue which would need to be suppressed for the time being like I commented in #10667 (review) (else the CI checks fail) 👍

[ohmyide]

@ohmyide I understand the fix :) I confirmed that it works and you actually helped identify an issue which would need to be suppressed for the time being like I commented in #10667 (review) (else the CI checks fail) 👍

ok, thanks for your prompt reply

[vince-fugnitto]

@ohmyide do you mind rebasing the pull-request and making the change I mentioned here? If you need any help please let me know! :)

[ohmyide]

@vince-fugnitto
done.
I add an eslint-disable-next-line in plugin-ext/src/common/plugin-api-rpc.ts

[vince-fugnitto]

The changes look good to me, thank you for your contribution 👍
@paul-marechal do you have any objections?