fix npm publishing #10686
Merged
fix npm publishing #10686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paul-marechal
added
theia-cli
Turns out the `binding.gyp` file is not published by default, we must explicitly include it in our `package.json`... Clean-up and add missing files to be published on npm.
paul-marechal
force-pushed
the
mp/ffmpeg-binding-gyp
branch
from
0bb9ff4 to
c1d8414
Compare
3 tasks
vince-fugnitto
approved these changes
Jan 28, 2022
There was a problem hiding this comment.
I confirmed that I was able to build an electron application thanks to the updates (using local npm links):
{
"private": true,
"theia": {
"target": "electron",
"frontend": {
"config": {
"applicationName": "Theia Electron"
}
}
},
"dependencies": {
"@theia/callhierarchy": "latest",
"@theia/electron": "file:/home/vin/workspaces/theia-work/packages/electron",
"@theia/file-search": "latest",
"@theia/git": "latest",
"@theia/markers": "latest",
"@theia/messages": "latest",
"@theia/mini-browser": "latest",
"@theia/navigator": "latest",
"@theia/outline-view": "latest",
"@theia/plugin-ext-vscode": "latest",
"@theia/preferences": "latest",
"@theia/preview": "latest",
"@theia/search-in-workspace": "latest",
"@theia/terminal": "latest"
},
"devDependencies": {
"@theia/cli": "latest",
"electron": "^15.3.5"
},
"resolutions": {
"**/@theia/ffmpeg": "file:/home/vin/workspaces/theia-work/dev-packages/ffmpeg"
}
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out the
binding.gypfile is not published by default, we mustexplicitly include it in our
package.json...Clean-up and add missing files to be published on npm.