Correctly expose extensionUri for frontend modules #10747
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Depends on #10721.
The
extensionContext.extensionUri
was incorrectly returning afile
schemed Uri for frontend modules.This meant loading assets based on
context.extensionUri
wasn't possible (and breaks some loading in VS Code web extensions)This PR ensures
extensionUri
is correctly formed based on the type of module.It also updates the
pluginContext
to use the underlyingplugin
extensionPath
andextensionUri
fields rather than recalculating them.How to test
Create a frontend module (VS Code web extension or Theia frontend plugin) and inspect the
context.extensionUri
;Review checklist
Reminder for reviewers