Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add migration step for the socket.io update on Theia 1.23 #10838

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

drochgenius
Copy link
Contributor

@drochgenius drochgenius commented Mar 3, 2022

What it does

Add new migration step in the Migration Guide related to the socket.io update on Theia 1.23.

How to test

Nothing to test, it's a documentation update.

Review checklist

Reminder for reviewers

@drochgenius drochgenius marked this pull request as ready for review March 3, 2022 19:11
Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@paul-marechal
Copy link
Member

paul-marechal commented Mar 3, 2022

Ah, could you make sure to sign the Eclipse ECA? Your commit must be authored with the same email registered there.

https://accounts.eclipse.org/user/eca

@vince-fugnitto vince-fugnitto added the documentation issues related to documentation label Mar 3, 2022
@drochgenius
Copy link
Contributor Author

Hi @paul-marechal , I have signed the Eclipse ECA.

@paul-marechal
Copy link
Member

paul-marechal commented Mar 3, 2022

The ECA check keeps failing even after revalidation. I don't know what email you used when signing, but the Git commit was made using [email protected]. Make sure you used the same email while both signing the ECA and authoring commits.

@drochgenius
Copy link
Contributor Author

I have signed the agreement, but somehow it doesn't want to clear the check.

@paul-marechal paul-marechal merged commit 716bb83 into eclipse-theia:master Mar 4, 2022
@vince-fugnitto vince-fugnitto added this to the 1.24.0 milestone Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants