Update windows-build-tools installation instructions #10862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
windows-build-tools is now deprecated since NodeJs installer can now install all of its required tools. This commit updates the instructions on how to build Theia on Windows to inform developers about the deprecation of windows-build-tools and mark the installation instruction of the tool as fallback. Signed-off-by: Hoang Thuan Pham <[email protected]>
vince-fugnitto
added
documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
windows-build-tools is now deprecated since NodeJs installer can now install all of its required tools. This commit updates the instructions on how to build Theia on Windows to inform developers about the deprecation of windows-build-tools and mark the installation instruction of the tool as fallback.
This commit closes Issue #10856.
How to test
See Issue #10856.
Review checklist
Reminder for reviewers