Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure compression parent is also visible #10872

Conversation

colin-grant-work
Copy link
Contributor

What it does

Fixes a bug in which folders could get compressed into an invisible workspace root.

How to test

  1. Create a directory that has a single, empty directory as its only child.
  2. Open that directory as a workspace.
  3. Observe that the child folder is visible under both settings of the explorer.compactFolders preference.
  4. Use the examples/compression-example workspace to ensure that other compression features continue to work as usual.

Review checklist

Reminder for reviewers

@colin-grant-work colin-grant-work added bug bugs found in the application navigator issues related to the navigator/explorer labels Mar 10, 2022
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good to me 👍
I confirmed that it fixes the bug, and that the compression-example works well.

master:

compress-bug

pull-request:

compress-fix

The workspace structure looked like:

$ tree
.
|____.theia

@colin-grant-work colin-grant-work merged commit 8b7f7a0 into eclipse-theia:master Mar 11, 2022
@colin-grant-work colin-grant-work deleted the bugfix/no-invisible-compression-parents branch March 11, 2022 18:15
@colin-grant-work colin-grant-work added this to the 1.24.0 milestone Mar 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application navigator issues related to the navigator/explorer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants